Harden GenerationGuide runtime validation#60
Closed
christopherkarani wants to merge 1 commit into
Closed
Conversation
- replace precondition traps in public guide builders with unsupported/no-op fallback - add regression tests for empty anyOf and negative array count guides - verify with targeted guide tests, full swift test, and swift build
Owner
Author
|
Closing as superseded. The GenerationGuide runtime validation fix was already landed via PR #59, and this branch is now stale/conflicting with no remaining unique merge value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a production safety gap in Conduit’s public generation-guide API by removing process-terminating preconditions from runtime-facing guide builders and replacing them with safe no-op behavior.
Problem
Several public guide constructors used
precondition(...)on values that may originate from dynamic runtime paths (including user/config-driven inputs):GenerationGuide<String>.anyOf(_:)with empty arraysGenerationGuide<[Element]>.minimumCount(_:)with negative valuesGenerationGuide<[Element]>.maximumCount(_:)with negative valuesGenerationGuide<[Element]>.count(_:)for negative exact countsGenerationGuide<[Element]>.count(_:)for ranges with negative lower boundsIn production apps, hitting these branches terminates the process.
Changes
.unsupported(no-op constraint).GenerationGuideValidationTestsproving:anyOfguide degrades to no-op (no enum emitted)Why this design
.unsupportedalready exists as an intentional no-op constraint path and integrates cleanly with schema generation.Verification
swift test --filter GenerationGuideValidationTestsswift testswift buildAll passed locally.