Skip to content

Google Sheets Add Row reports success text when the action failed #987

Description

@notdodo-prima

Describe the bug
The Google Sheets Add Row action can fail while still returning the output message Row added to the sheet successfully and a hardcoded successful result value. The exception branch sets status = EXECUTION_STATE_FAILED, but the action always ends with a success message and True result value.

Confirmed in current main at 2a6aa9d40e3ba5ba17787691018069d6a1498cd3:

except Exception as err:
siemplify.LOGGER.error(err)
status = EXECUTION_STATE_FAILED
else:
status = EXECUTION_STATE_COMPLETED
siemplify.end("Row added to the sheet successfully", True, status)

To Reproduce
Steps to reproduce the behavior:

  1. Run Google Sheets - Add Row.
  2. Provide parameters that make the action fail, for example an unresolved/non-numeric Row Index expression.
  3. Observe that the action status is failed.
  4. Observe that the output message still says Row added to the sheet successfully.

Observed UI snippet:

Action: Failed
Output message:
Row added to the sheet successfully

Expected behavior
On failure, the action should return a failure message with the exception details and should not use a hardcoded success message/result value when status = EXECUTION_STATE_FAILED.

Additional context
This makes playbook troubleshooting misleading because the action status and output message disagree.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions