Describe the bug
The Google Sheets Add Row action can fail while still returning the output message Row added to the sheet successfully and a hardcoded successful result value. The exception branch sets status = EXECUTION_STATE_FAILED, but the action always ends with a success message and True result value.
Confirmed in current main at 2a6aa9d40e3ba5ba17787691018069d6a1498cd3:
|
except Exception as err: |
|
siemplify.LOGGER.error(err) |
|
status = EXECUTION_STATE_FAILED |
|
else: |
|
status = EXECUTION_STATE_COMPLETED |
|
|
|
siemplify.end("Row added to the sheet successfully", True, status) |
To Reproduce
Steps to reproduce the behavior:
- Run
Google Sheets - Add Row.
- Provide parameters that make the action fail, for example an unresolved/non-numeric
Row Index expression.
- Observe that the action status is failed.
- Observe that the output message still says
Row added to the sheet successfully.
Observed UI snippet:
Action: Failed
Output message:
Row added to the sheet successfully
Expected behavior
On failure, the action should return a failure message with the exception details and should not use a hardcoded success message/result value when status = EXECUTION_STATE_FAILED.
Additional context
This makes playbook troubleshooting misleading because the action status and output message disagree.
Describe the bug
The Google Sheets
Add Rowaction can fail while still returning the output messageRow added to the sheet successfullyand a hardcoded successful result value. The exception branch setsstatus = EXECUTION_STATE_FAILED, but the action always ends with a success message andTrueresult value.Confirmed in current
mainat2a6aa9d40e3ba5ba17787691018069d6a1498cd3:content-hub/content/response_integrations/third_party/community/google_sheets/actions/AddRow.py
Lines 45 to 51 in 2a6aa9d
To Reproduce
Steps to reproduce the behavior:
Google Sheets - Add Row.Row Indexexpression.Row added to the sheet successfully.Observed UI snippet:
Expected behavior
On failure, the action should return a failure message with the exception details and should not use a hardcoded success message/result value when
status = EXECUTION_STATE_FAILED.Additional context
This makes playbook troubleshooting misleading because the action status and output message disagree.