Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke Tests are leaking information #1579

Open
1 task
james-garriss opened this issue Feb 19, 2025 · 2 comments
Open
1 task

Smoke Tests are leaking information #1579

james-garriss opened this issue Feb 19, 2025 · 2 comments
Labels
enhancement This issue or pull request will add new or improve existing functionality good first issue This issue or pull request is well-defined and good for newcomers infrastructure Related to configuring infrastructure necessary for the project
Milestone

Comments

@james-garriss
Copy link
Collaborator

james-garriss commented Feb 19, 2025

💡 Summary

The smoke tests are leaking information they should keep private. Remove the leaked info while, if possible, still making it obvious where any problems are.

Motivation and context

Some information should not be revealed.

Implementation notes

  • Look at smoke test runs.
  • Find the info that is being leaked.
  • Modify the smoke tests to avoid this problem.
  • Modify any other repo files necessary as well.
  • Win!

Acceptance criteria

How do we know when this work is done?

  • The smoke tests are sealed better than a submarine.
@james-garriss james-garriss added enhancement This issue or pull request will add new or improve existing functionality good first issue This issue or pull request is well-defined and good for newcomers infrastructure Related to configuring infrastructure necessary for the project labels Feb 19, 2025
@james-garriss
Copy link
Collaborator Author

Addam noted:

IIRC it is a matrix thing and it's just a matter of getting the alias injected into the Pester test name instead of the true name. Might be harder to do than it sounds, and may need to add more data to the JSON secret blob to do so.

@james-garriss
Copy link
Collaborator Author

This and other leaked info appears in multiple files. Contact me for details on how to find them. These should all be cleaned up at once.

@schrolla schrolla added this to the Marlin milestone Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request will add new or improve existing functionality good first issue This issue or pull request is well-defined and good for newcomers infrastructure Related to configuring infrastructure necessary for the project
Projects
None yet
Development

No branches or pull requests

2 participants