generated from cisagov/ScubaGear
-
Notifications
You must be signed in to change notification settings - Fork 47
Closed
Description
💡 Summary
For regular update and maintenance of ScubaGoggles, the permissions required of the module should be abstracted to a separate file instead of hardcoded within auth.py. This is so scripts or other code utilizing ScubaGoggles can check for permission updates.
Motivation and context
Easier future maintenance of ScubaGoggles permissions for code utilizing ScubaGoggles.
Implementation notes
- Abstract out the OAuth scopes array in
auth.pyto scuba_constants.py
Acceptance criteria
- Permissions for ScubaGoggles are abstracted out to scuba_constants.py
- - Update
auth.pyto reference the scuba constants variable - - For the permissions file abstracted issue, we test and ensure both OAuth and service account authentication both still work.