Skip to content

Conversation

@jsf9k
Copy link
Member

@jsf9k jsf9k commented Jul 9, 2025

🗣 Description

This pull request updates the format of the build status badge URL that appears in the Mustache template.

💭 Motivation and context

I'm not sure what happens on the backend, but using the newer URL format seems to give more reliable results. Right now, for instance, the old URL format indicates failure for cisagov/skeleton-ansible-role-with-test-user while the new URL format correctly indicates success.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.
  • Bump major, minor, patch, pre-release, and/or build versions as appropriate via the bump_version script if this repository is versioned and the changes in this PR warrant a version bump.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release (necessary if and only if the version was bumped).

@jsf9k jsf9k self-assigned this Jul 9, 2025
@jsf9k jsf9k added bug This issue or pull request addresses broken functionality version bump This issue or pull request increments the version number python Pull requests that update Python code labels Jul 9, 2025
@jsf9k jsf9k marked this pull request as ready for review July 9, 2025 17:10
@jsf9k jsf9k requested review from dav3r, felddy and mcdonnnj as code owners July 9, 2025 17:10
@jsf9k jsf9k requested a review from a team July 9, 2025 17:10
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the new URL, which follows the documentation, uses the default branch unless overridden, whereas the old one is the workflow's last run's status without regard for branch. That would align with the results you're seeing since the last run on develop is a pass and the last run period is a failure.

@jsf9k
Copy link
Member Author

jsf9k commented Jul 9, 2025

I think the new URL, which follows the documentation, uses the default branch unless overridden, whereas the old one is the workflow's last run's status without regard for branch. That would align with the results you're seeing since the last run on develop is a pass and the last run period is a failure.

I think you're right. I also think the new URL aligns with the changes I made in cisagov/action-apb#69 and the intent of APB.

@jsf9k jsf9k merged commit d966025 into develop Jul 9, 2025
52 checks passed
@jsf9k jsf9k deleted the bugfix/update-badge-link-url branch July 9, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue or pull request addresses broken functionality python Pull requests that update Python code version bump This issue or pull request increments the version number

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants