Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility improvement on "Start a new domain request" button on domain management dashboard #1300

Open
1 task
gabo0oo opened this issue Nov 8, 2023 · 3 comments · May be fixed by #3594
Open
1 task
Assignees
Labels
accessibility pertains to Section 508 compliance or other accessibility needs 👥 Pod:Accessibility Compliance Describes work needed for get.gov and manage.get.gov to be Section 508 Compliant dev issue is for the dev team refinement

Comments

@gabo0oo
Copy link
Contributor

gabo0oo commented Nov 8, 2023

In a previous review, I noticed that the way we have semantically set up our CTA button on the domain dashboard is not in line with USWDS recommendations. In voice over, the button is read off as a link, not a button. There is also a different order that this element is read that is opposite how USWDS has their button set up. This seems to be an issue with how the page was designed initially where this button got a <a> tag rather than a <button> tag. In USWDS, the label gets read off first, but in ours it's last. See the below examples for reference.
Additionally we may want to do a deeper dive of our buttons set up with VO on other pages to make sure they are set up correctly.

our button (button label last)
Screenshot 2023-11-07 at 9 31 03 PM

uswds button (button label first)
Screenshot 2023-11-07 at 9 37 25 PM

Originally posted by @gabydisarli in #1256 (comment)

Slack thread

Acceptance Criteria:

  • Update the element style for CTA button "Start a new domain request" on the domain dashboard from < a > to < button >

Prioritization Comments

WCAG Conformance Level: 2.1 AA
WCAG Standard that applies:
4.1.2 Name, role, value (Critical)
3.3.2 Labels/Instructions (Critical)
Critical Failure if Not Met?: Yes
Prioritization: High/Must Do
Reason: buttons are not semantically correct, this would normally be a blocker, however enough context is given to the user relying on a screen reader in this case.

@PaulKuykendall
Copy link

@rachidatecs - easy/hard?? Thoughts?

I'd like to fix for launch if it's not too much. Just to be cleaner.

@PaulKuykendall PaulKuykendall moved this from 👶 New to 🍦 Backlog in .gov Product Board Jan 4, 2024
@vickyszuchin vickyszuchin added the dev issue is for the dev team label Jan 4, 2024
@Katherine-MN Katherine-MN removed their assignment Jan 5, 2024
@Katherine-MN
Copy link
Contributor

@katypies katypies added the accessibility pertains to Section 508 compliance or other accessibility needs label Jun 24, 2024
@zandercymatics zandercymatics added the 👥 Pod:Accessibility Compliance Describes work needed for get.gov and manage.get.gov to be Section 508 Compliant label Feb 14, 2025
@CocoByte CocoByte self-assigned this Feb 14, 2025
@CocoByte CocoByte moved this from 🍦 Backlog to 🔖 Planned in .gov Product Board Feb 18, 2025
@SamiyahKey
Copy link

@CocoByte this AC has been clarified!

@CocoByte CocoByte moved this from 🔖 Planned to 🏗 In progress in .gov Product Board Feb 27, 2025
@CocoByte CocoByte moved this from 🏗 In progress to 👀 In review in .gov Product Board Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility pertains to Section 508 compliance or other accessibility needs 👥 Pod:Accessibility Compliance Describes work needed for get.gov and manage.get.gov to be Section 508 Compliant dev issue is for the dev team refinement
Projects
Status: 👀 In review
8 participants