You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When a domain is deleted, we want to allow another request to be approved with the same domain name. However, we had one case where the old domain was deleted and another domain request with the same domain name was approved that same day. This created a problem because the domain was still in the status "pendingDelete", which means it still existed in the registry and a new domain could not be made. This caused the new approved Domain to have several errors.
When a domain of the same name was deleted, we should check if the domain is still pendingDelete when an analyst approves the domain. If it's pending delete we should show a message to analysts and block the approval.
Acceptance criteria
when a domain request is being approved and a domain of the same name is in a deleted state, check for the domain status pendingDelete
if this domain has the status pendingdelete, then show an error to the analyst and block the transition to approved. And thus do not create any new domain/domain info object yet
Additional context
pendingDelete is a "status" from the registry, see models/domain.py function "statuses" which is a getter. Note that you will need to handle the keyerror, as this will get triggered if the domain is already deleted successfully. Alternatively, you could use the checkDomain function to see if the domain is available yet before checking the status and avoid keyerror handling.
slack thread with more information on the errors that occurred when pendingDelete wasn't checked
Issue description
When a domain is deleted, we want to allow another request to be approved with the same domain name. However, we had one case where the old domain was deleted and another domain request with the same domain name was approved that same day. This created a problem because the domain was still in the status "pendingDelete", which means it still existed in the registry and a new domain could not be made. This caused the new approved Domain to have several errors.
When a domain of the same name was deleted, we should check if the domain is still pendingDelete when an analyst approves the domain. If it's pending delete we should show a message to analysts and block the approval.
Acceptance criteria
Additional context
pendingDelete is a "status" from the registry, see models/domain.py function "statuses" which is a getter. Note that you will need to handle the keyerror, as this will get triggered if the domain is already deleted successfully. Alternatively, you could use the checkDomain function to see if the domain is available yet before checking the status and avoid keyerror handling.
slack thread with more information on the errors that occurred when pendingDelete wasn't checked
Links to other issues
The text was updated successfully, but these errors were encountered: