Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for pendingdelete status when approving a domain again #3596

Open
2 tasks
Tracked by #3597
allly-b opened this issue Feb 28, 2025 · 0 comments
Open
2 tasks
Tracked by #3597

Check for pendingdelete status when approving a domain again #3596

allly-b opened this issue Feb 28, 2025 · 0 comments
Labels
bundled Parent ticket will be sprinted and this ticket is included in the parent dev issue is for the dev team

Comments

@allly-b
Copy link
Contributor

allly-b commented Feb 28, 2025

Issue description

When a domain is deleted, we want to allow another request to be approved with the same domain name. However, we had one case where the old domain was deleted and another domain request with the same domain name was approved that same day. This created a problem because the domain was still in the status "pendingDelete", which means it still existed in the registry and a new domain could not be made. This caused the new approved Domain to have several errors.

When a domain of the same name was deleted, we should check if the domain is still pendingDelete when an analyst approves the domain. If it's pending delete we should show a message to analysts and block the approval.

Acceptance criteria

  • when a domain request is being approved and a domain of the same name is in a deleted state, check for the domain status pendingDelete
  • if this domain has the status pendingdelete, then show an error to the analyst and block the transition to approved. And thus do not create any new domain/domain info object yet

Additional context

pendingDelete is a "status" from the registry, see models/domain.py function "statuses" which is a getter. Note that you will need to handle the keyerror, as this will get triggered if the domain is already deleted successfully. Alternatively, you could use the checkDomain function to see if the domain is available yet before checking the status and avoid keyerror handling.

slack thread with more information on the errors that occurred when pendingDelete wasn't checked

Links to other issues

@allly-b allly-b added the dev issue is for the dev team label Feb 28, 2025
@allly-b allly-b moved this from 👶 New to 🎯 Ready in .gov Product Board Feb 28, 2025
@allly-b allly-b moved this from 🎯 Ready to 👶 New in .gov Product Board Feb 28, 2025
@allly-b allly-b added the bundled Parent ticket will be sprinted and this ticket is included in the parent label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bundled Parent ticket will be sprinted and this ticket is included in the parent dev issue is for the dev team
Projects
Status: 👶 New
Development

No branches or pull requests

1 participant