fix(aiohttp): fixed Nimrod's CR

Author: osherv

cisco_telescope/instrumentations/aiohttp/__init__.py

@@ -192,7 +192,7 @@ def _decode_chunk(chunk):
             decoded_chunk = chunk.decode()
         except UnicodeDecodeError as e:
             decoded_chunk = str(chunk)
-            logging.info(f"Could'nt decode the chunk: {decoded_chunk}, {e}")
+            logging.info(f"Could not decode body chunk: {decoded_chunk}, {e}")
 
         return decoded_chunk
 

tests/instrumentations/test_aiohttp.py

@@ -71,26 +71,28 @@ async def test_post_request_sanity(self):
 
     async def test_post_request_invalid_utf8(self):
         Configuration().payloads_enabled = True
-        data_to_send = b'/">Miso\xdfNoContinuation'
-        async with aiohttp.client.request(
-            method="POST",
-            url=self.http_url_sanity,
-            headers=self.request_headers(),
-            chunked=True,
-            data=data_to_send,
-        ) as resp:
-            self._assert_basic_attributes_and_headers(resp)
-            spans = self.memory_exporter.get_finished_spans()
-            span = spans[0]
-
-            self.assertEqual(
-                span.attributes[SemanticAttributes.HTTP_REQUEST_BODY],
-                str(data_to_send),
-            )
-            self.assertEqual(
-                span.attributes[SemanticAttributes.HTTP_RESPONSE_BODY],
-                self.response_body(),
-            )
+        with self.assertLogs() as logs_written:
+            data_to_send = b'/">Miso\xdfNoContinuation'
+            async with aiohttp.client.request(
+                method="POST",
+                url=self.http_url_sanity,
+                headers=self.request_headers(),
+                chunked=True,
+                data=data_to_send,
+            ) as resp:
+                self._assert_basic_attributes_and_headers(resp)
+                spans = self.memory_exporter.get_finished_spans()
+                span = spans[0]
+
+                self.assertEqual(
+                    span.attributes[SemanticAttributes.HTTP_REQUEST_BODY],
+                    str(data_to_send),
+                )
+                self.assertEqual(
+                    span.attributes[SemanticAttributes.HTTP_RESPONSE_BODY],
+                    self.response_body(),
+                )
+                self.assertEqual(len(logs_written.records), 1)
 
     async def test_get_request_error(self):
         Configuration().payloads_enabled = True