From f73a0eaee3bb7c8454c0a6469c31897fbf71ecf7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?G=C3=BCrkan=20=C4=B0ndibay?= Date: Thu, 7 Oct 2021 09:32:02 +0300 Subject: [PATCH 1/7] Adds issue templates for other projects --- ...s-enterprise-release-checklist-template.md | 62 +++++++++++++++++++ .../citus-packaging-request-template.md | 3 +- ...r-enterprise-release-checklist-template.md | 62 +++++++++++++++++++ ...uto-failover-release-checklist-template.md | 30 +++++++++ 4 files changed, 156 insertions(+), 1 deletion(-) create mode 100644 .github/ISSUE_TEMPLATE/citus-enterprise-release-checklist-template.md create mode 100644 .github/ISSUE_TEMPLATE/pg-auto-failover-enterprise-release-checklist-template.md create mode 100644 .github/ISSUE_TEMPLATE/pg-auto-failover-release-checklist-template.md diff --git a/.github/ISSUE_TEMPLATE/citus-enterprise-release-checklist-template.md b/.github/ISSUE_TEMPLATE/citus-enterprise-release-checklist-template.md new file mode 100644 index 000000000..177e0edb6 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/citus-enterprise-release-checklist-template.md @@ -0,0 +1,62 @@ +--- +name: citus-enterprise release checklist template +about: Please make sure to follow the checklist below along the release process. +title: Citus Enterprise release checklist - [vX.Y.Z] +labels: release_checklist +assignees: gurkanindibay + +--- + +## Several things to note here + +These instructions assume you have `$VERSION`, `$PROJECT`, and `$REPO` environment variables set in your shell (e.g. `10.0.2`, `citus`, and `citus`). With those set, code from most steps can be copy-pasted. + +**After this checklist, you're still not done: open a release checklist for Enterprise too!** + +# Update OS Packages +## Debian and RedHat +- Change your directory to `packaging` repository directory & checkout `all-$PROJECT` branch. +- [ ] Run the pipeline using branch name as all-$PROJECT https://github.com/citusdata/packaging/actions/workflows/update_package_properties.yml. Input tag name and if version is fancy, input the fancy version_no. Other parameters could be kept as is if you want + - Then check the following (needed for both debian & redhat): + - [ ] Updated `pkglatest` variable in the `pkgvars` file to `$VERSION.citus-1` + - Then check the following (needed for debian): + - [ ] A new entry (`$VERSION.citus-1`, `stable`) is added to the `debian/changelog` file + - Then check the following (needed for redhat): + - [ ] `$PROJECT.spec` file is updated: + - [ ] `Version:` field + - [ ] `Source0:` field + - [ ] A new entry (`$VERSION.citus-1`) in the `%changelog` section +- [ ] Get changes reviewed; merge the PR +- [ ] Ensure Github Actions builds completed successfully and package count for each os is as below table and packages in postgres versions is compliant with `postgres-matrix.yml` in the `all-project` branch + +https://github.com/citusdata/tools/blob/be12af3b8f435d17a52e607c666f6b15379f5970/packaging_automation/tests/test_citus_package.py#L21-L33 + +## Microsoft Packages + +- [ ] Add vso (Visual Studio Online) remote to your local git checkout of the github packaging repo (only needed once): +`git remote add vso msdata@vs-ssh.visualstudio.com:v3/msdata/Database%20Systems/citus-packaging` +- [ ] To trigger a test build on Azure DevOps: +`git checkout all-enterprise` +`git pull # from normal github origin` +`git push vso # update Azure DevOps mirror` +- [ ] Go here: https://msdata.visualstudio.com/Database%20Systems/_build?definitionId=10018&_a=summary +- [ ] Wait for build to succeed. If build does not success, go here: +https://msdata.visualstudio.com/Database%20Systems/_apps/hub/ms.vss-ciworkflow.build-ci-hub?_a=edit-build-definition&id=10018. +Maybe you need to update some parameters there (like the tools repo version). Then save it without queuing and then “Run pipeline” again via the first link. +- [ ] Check that it created the right packages by looking at the logs and artifacts (the button with the box/drawer icon and text “8 published”). + - [ ] Click there, and see 7 items in signed packages + centos 6/7/8 + debian buster/stretch + ubuntu bionic/xenial + - [ ] Check logs for each of 7 builds, by clicking `View raw log` +- [ ] Go back to the overview: https://msdata.visualstudio.com/Database%20Systems/_build?definitionId=10018&_a=summary +- [ ] Click “Run pipeline” +- [ ] Click “Variables” +- [ ] Change PUBLISH_TO_PACKAGE_REPO to “true” +- [ ] Go back after doing so and click "Run” +- [ ] Wait until completed. +- [ ] Check if packages are successfully published using below links: + - [ ] 6 new items for the version for Ubuntu (xenial , bionic and focal): https://packages.microsoft.com/repos/citus-ubuntu/pool/main/c/citus-enterprise/ + - [ ] 4 new items for the version for Debian (buster and stretch): https://packages.microsoft.com/repos/citus-debian/pool/main/c/citus-enterprise/ ( for release >9.4 and < 9.5, 4 package is expected. Since 9.5 6 package is expected) + - [ ] 2 new items for the version for CentOS7/RHEL7: https://packages.microsoft.com/yumrepos/citus-centos7/ + - [ ] 2 new items for the version for CentOS8/RHEL8: https://packages.microsoft.com/yumrepos/citus-centos8/ diff --git a/.github/ISSUE_TEMPLATE/citus-packaging-request-template.md b/.github/ISSUE_TEMPLATE/citus-packaging-request-template.md index 28480eb5d..6be77b41b 100644 --- a/.github/ISSUE_TEMPLATE/citus-packaging-request-template.md +++ b/.github/ISSUE_TEMPLATE/citus-packaging-request-template.md @@ -2,7 +2,7 @@ name: Citus release checklist template about: Please make sure to follow the checklist below along the release process. title: Citus release checklist - [vX.Y.Z] -labels: release checklist +labels: '' assignees: gurkanindibay --- @@ -28,6 +28,7 @@ These instructions assume you have `$VERSION`, `$PROJECT`, and `$REPO` environme - [ ] A new entry (`$VERSION.citus-1`) in the `%changelog` section - [ ] Get changes reviewed; merge the PR - [ ] Ensure Github Actions builds completed successfully and package count for each os is as below table and packages in postgres versions is compliant with `postgres-matrix.yml` in the `all-project` branch +https://github.com/citusdata/tools/blob/be12af3b8f435d17a52e607c666f6b15379f5970/packaging_automation/tests/test_citus_package.py#L21-L33 # Update Docker Note that we create docker images for only the latest version of Citus. So, you don’t need to update it if you are releasing a point version of an older major version. diff --git a/.github/ISSUE_TEMPLATE/pg-auto-failover-enterprise-release-checklist-template.md b/.github/ISSUE_TEMPLATE/pg-auto-failover-enterprise-release-checklist-template.md new file mode 100644 index 000000000..87f3c6c71 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/pg-auto-failover-enterprise-release-checklist-template.md @@ -0,0 +1,62 @@ +--- +name: pg-auto-failover-enterprise release checklist template +about: Please make sure to follow the checklist below along the release process. +title: Pg Auto Failover Enterprise release checklist - [vX.Y.Z] +labels: release_checklist +assignees: gurkanindibay + +--- + +## Several things to note here + +These instructions assume you have `$VERSION`, `$PROJECT`, and `$REPO` environment variables set in your shell (e.g. `10.0.2`, `citus`, and `citus`). With those set, code from most steps can be copy-pasted. + +**After this checklist, you're still not done: open a release checklist for Enterprise too!** + +# Update OS Packages +## Debian and RedHat +- Change your directory to `packaging` repository directory & checkout `all-$PROJECT` branch. +- [ ] Run the pipeline using branch name as all-$PROJECT https://github.com/citusdata/packaging/actions/workflows/update_package_properties.yml. Input tag name and if version is fancy, input the fancy version_no. Other parameters could be kept as is if you want + - Then check the following (needed for both debian & redhat): + - [ ] Updated `pkglatest` variable in the `pkgvars` file to `$VERSION.citus-1` + - Then check the following (needed for debian): + - [ ] A new entry (`$VERSION.citus-1`, `stable`) is added to the `debian/changelog` file + - Then check the following (needed for redhat): + - [ ] `$PROJECT.spec` file is updated: + - [ ] `Version:` field + - [ ] `Source0:` field + - [ ] A new entry (`$VERSION.citus-1`) in the `%changelog` section +- [ ] Get changes reviewed; merge the PR +- [ ] Ensure Github Actions builds completed successfully and package count for each os is as below table and packages in postgres versions is compliant with `postgres-matrix.yml` in the `all-project` branch + +https://github.com/citusdata/tools/blob/be12af3b8f435d17a52e607c666f6b15379f5970/packaging_automation/tests/test_citus_package.py#L21-L33 + +## Microsoft Packages + +- [ ] Add vso (Visual Studio Online) remote to your local git checkout of the github packaging repo (only needed once): +`git remote add vso msdata@vs-ssh.visualstudio.com:v3/msdata/Database%20Systems/citus-packaging` +- [ ] To trigger a test build on Azure DevOps: +`git checkout all-pgautofailover-enterprise` +`git pull # from normal github origin` +`git push vso # update Azure DevOps mirror` +- [ ] Go here: https://msdata.visualstudio.com/Database%20Systems/_build?definitionId=10018&_a=summary +- [ ] Wait for build to succeed. If build does not success, go here: +https://msdata.visualstudio.com/Database%20Systems/_apps/hub/ms.vss-ciworkflow.build-ci-hub?_a=edit-build-definition&id=10018. +Maybe you need to update some parameters there (like the tools repo version). Then save it without queuing and then “Run pipeline” again via the first link. +- [ ] Check that it created the right packages by looking at the logs and artifacts (the button with the box/drawer icon and text “8 published”). + - [ ] Click there, and see 7 items in signed packages + centos 6/7/8 + debian buster/stretch + ubuntu bionic/xenial + - [ ] Check logs for each of 7 builds, by clicking `View raw log` +- [ ] Go back to the overview: https://msdata.visualstudio.com/Database%20Systems/_build?definitionId=10018&_a=summary +- [ ] Click “Run pipeline” +- [ ] Click “Variables” +- [ ] Change PUBLISH_TO_PACKAGE_REPO to “true” +- [ ] Go back after doing so and click "Run” +- [ ] Wait until completed. +- [ ] Check if packages are successfully published using below links: + - [ ] 6 new items for the version for Ubuntu (xenial , bionic and focal): https://packages.microsoft.com/repos/citus-ubuntu/pool/main/c/citus-enterprise/ + - [ ] 4 new items for the version for Debian (buster and stretch): https://packages.microsoft.com/repos/citus-debian/pool/main/c/citus-enterprise/ ( for release >9.4 and < 9.5, 4 package is expected. Since 9.5 6 package is expected) + - [ ] 2 new items for the version for CentOS7/RHEL7: https://packages.microsoft.com/yumrepos/citus-centos7/ + - [ ] 2 new items for the version for CentOS8/RHEL8: https://packages.microsoft.com/yumrepos/citus-centos8/ diff --git a/.github/ISSUE_TEMPLATE/pg-auto-failover-release-checklist-template.md b/.github/ISSUE_TEMPLATE/pg-auto-failover-release-checklist-template.md new file mode 100644 index 000000000..3424bfb4d --- /dev/null +++ b/.github/ISSUE_TEMPLATE/pg-auto-failover-release-checklist-template.md @@ -0,0 +1,30 @@ +--- +name: pg-auto-failover release checklist template +about: Please make sure to follow the checklist below along the release process. +title: Pg Auto Failover release checklist - [vX.Y.Z] +labels: release_checklist +assignees: gurkanindibay + +--- + +## Several things to note here + +These instructions assume you have `$VERSION`, `$PROJECT`, and `$REPO` environment variables set in your shell (e.g. `10.0.2`, `citus`, and `citus`). With those set, code from most steps can be copy-pasted. + +**After this checklist, you're still not done: open a release checklist for Enterprise too!** + +# Update OS Packages +## Debian and RedHat +- Change your directory to `packaging` repository directory & checkout `all-$PROJECT` branch. +- [ ] Run the pipeline using branch name as all-project https://github.com/citusdata/packaging/actions/workflows/update_package_properties.yml. Input tag name and if version is fancy, input the fancy version_no. Other parameters could be kept as is if you want + - Then check the following (needed for both debian & redhat): + - [ ] Updated `pkglatest` variable in the `pkgvars` file to `$VERSION.citus-1` + - Then check the following (needed for debian): + - [ ] A new entry (`$VERSION.citus-1`, `stable`) is added to the `debian/changelog` file + - Then check the following (needed for redhat): + - [ ] `$PROJECT.spec` file is updated: + - [ ] `Version:` field + - [ ] `Source0:` field + - [ ] A new entry (`$VERSION.citus-1`) in the `%changelog` section +- [ ] Get changes reviewed; merge the PR +- [ ] Ensure Github Actions builds completed successfully and package count for each os is as below table and packages in postgres versions is compliant with `postgres-matrix.yml` in the `all-project` branch From 773dc5f1ecc3dfc71ff622c4b3c33818cef003d4 Mon Sep 17 00:00:00 2001 From: gindibay Date: Thu, 7 Oct 2021 09:34:14 +0300 Subject: [PATCH 2/7] Adds tag for citus packaging template --- .github/ISSUE_TEMPLATE/citus-packaging-request-template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/citus-packaging-request-template.md b/.github/ISSUE_TEMPLATE/citus-packaging-request-template.md index 6be77b41b..d99f6b0e3 100644 --- a/.github/ISSUE_TEMPLATE/citus-packaging-request-template.md +++ b/.github/ISSUE_TEMPLATE/citus-packaging-request-template.md @@ -2,7 +2,7 @@ name: Citus release checklist template about: Please make sure to follow the checklist below along the release process. title: Citus release checklist - [vX.Y.Z] -labels: '' +labels: release_checklist assignees: gurkanindibay --- From f671a52992f281cd17184b1c702c0beb3ce9032f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?G=C3=BCrkan=20=C4=B0ndibay?= Date: Fri, 8 Oct 2021 15:42:14 +0300 Subject: [PATCH 3/7] Apply suggestions from code review Co-authored-by: Hanefi Onaldi --- .../pg-auto-failover-enterprise-release-checklist-template.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/pg-auto-failover-enterprise-release-checklist-template.md b/.github/ISSUE_TEMPLATE/pg-auto-failover-enterprise-release-checklist-template.md index 87f3c6c71..85a4c8628 100644 --- a/.github/ISSUE_TEMPLATE/pg-auto-failover-enterprise-release-checklist-template.md +++ b/.github/ISSUE_TEMPLATE/pg-auto-failover-enterprise-release-checklist-template.md @@ -1,7 +1,7 @@ --- name: pg-auto-failover-enterprise release checklist template about: Please make sure to follow the checklist below along the release process. -title: Pg Auto Failover Enterprise release checklist - [vX.Y.Z] +title: pg-auto-failover Enterprise release checklist - [vX.Y.Z] labels: release_checklist assignees: gurkanindibay @@ -16,7 +16,7 @@ These instructions assume you have `$VERSION`, `$PROJECT`, and `$REPO` environme # Update OS Packages ## Debian and RedHat - Change your directory to `packaging` repository directory & checkout `all-$PROJECT` branch. -- [ ] Run the pipeline using branch name as all-$PROJECT https://github.com/citusdata/packaging/actions/workflows/update_package_properties.yml. Input tag name and if version is fancy, input the fancy version_no. Other parameters could be kept as is if you want +- [ ] Run the pipeline using branch name as all-$PROJECT [update_package_properties workflow](https://github.com/citusdata/packaging/actions/workflows/update_package_properties.yml). Input tag name and if version is fancy, input the fancy version_no. Other parameters could be kept as is if you want - Then check the following (needed for both debian & redhat): - [ ] Updated `pkglatest` variable in the `pkgvars` file to `$VERSION.citus-1` - Then check the following (needed for debian): From 4483cb318cf2fcb30cbf1ec1a1414e5cd899c703 Mon Sep 17 00:00:00 2001 From: gindibay Date: Fri, 8 Oct 2021 15:56:11 +0300 Subject: [PATCH 4/7] Fixes review comments --- .../citus-enterprise-release-checklist-template.md | 10 ++-------- .../citus-packaging-request-template.md | 12 +++--------- ...failover-enterprise-release-checklist-template.md | 10 ++-------- .../pg-auto-failover-release-checklist-template.md | 10 ++-------- 4 files changed, 9 insertions(+), 33 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/citus-enterprise-release-checklist-template.md b/.github/ISSUE_TEMPLATE/citus-enterprise-release-checklist-template.md index 177e0edb6..63674320a 100644 --- a/.github/ISSUE_TEMPLATE/citus-enterprise-release-checklist-template.md +++ b/.github/ISSUE_TEMPLATE/citus-enterprise-release-checklist-template.md @@ -7,16 +7,10 @@ assignees: gurkanindibay --- -## Several things to note here - -These instructions assume you have `$VERSION`, `$PROJECT`, and `$REPO` environment variables set in your shell (e.g. `10.0.2`, `citus`, and `citus`). With those set, code from most steps can be copy-pasted. - -**After this checklist, you're still not done: open a release checklist for Enterprise too!** - # Update OS Packages ## Debian and RedHat -- Change your directory to `packaging` repository directory & checkout `all-$PROJECT` branch. -- [ ] Run the pipeline using branch name as all-$PROJECT https://github.com/citusdata/packaging/actions/workflows/update_package_properties.yml. Input tag name and if version is fancy, input the fancy version_no. Other parameters could be kept as is if you want +- Change your directory to `packaging` repository directory & checkout `all-enterprise` branch. +- [ ] Run the pipeline using branch name as all-enterprise https://github.com/citusdata/packaging/actions/workflows/update_package_properties.yml. Input tag name and if version is fancy, input the fancy version_no. Other parameters could be kept as is if you want - Then check the following (needed for both debian & redhat): - [ ] Updated `pkglatest` variable in the `pkgvars` file to `$VERSION.citus-1` - Then check the following (needed for debian): diff --git a/.github/ISSUE_TEMPLATE/citus-packaging-request-template.md b/.github/ISSUE_TEMPLATE/citus-packaging-request-template.md index d99f6b0e3..c8b00881c 100644 --- a/.github/ISSUE_TEMPLATE/citus-packaging-request-template.md +++ b/.github/ISSUE_TEMPLATE/citus-packaging-request-template.md @@ -7,16 +7,10 @@ assignees: gurkanindibay --- -## Several things to note here - -These instructions assume you have `$VERSION`, `$PROJECT`, and `$REPO` environment variables set in your shell (e.g. `10.0.2`, `citus`, and `citus`). With those set, code from most steps can be copy-pasted. - -**After this checklist, you're still not done: open a release checklist for Enterprise too!** - # Update OS Packages ## Debian and RedHat -- Change your directory to `packaging` repository directory & checkout `all-$PROJECT` branch. -- [ ] Run the pipeline using branch name as all-citus https://github.com/citusdata/packaging/actions/workflows/update_package_properties.yml. Input tag name and if version is fancy, input the fancy version_no. Other parameters could be kept as is if you want +- Change your directory to `packaging` repository directory & checkout `all-citus` branch. +- [ ] Run the pipeline using branch name as all-citus [update_package_properties workflow](https://github.com/citusdata/packaging/actions/workflows/update_package_properties.yml). Input tag name and if version is fancy, input the fancy version_no. Other parameters could be kept as is if you want - Then check the following (needed for both debian & redhat): - [ ] Updated `pkglatest` variable in the `pkgvars` file to `$VERSION.citus-1` - Then check the following (needed for debian): @@ -55,7 +49,7 @@ Note that we create docker images for only the latest version of Citus. So, you # Update PGXN - [ ] Run https://github.com/citusdata/packaging/actions/workflows/update-pgxn-version.yml on packaging repo, and check the following: - - [ ] Check out the `pgxn-$PROJECT` branch of the [packaging repository](https://github.com/citusdata/packaging) + - [ ] Check out the `pgxn-citus branch of the [packaging repository](https://github.com/citusdata/packaging) - [ ] All version occurrences are bumped in `META.json` - [ ] All version occurrences are bumped in `pkgvars` - [ ] After merging, ensure the Github Actions build completed successfully (a new release should appear in PGXN eventually) diff --git a/.github/ISSUE_TEMPLATE/pg-auto-failover-enterprise-release-checklist-template.md b/.github/ISSUE_TEMPLATE/pg-auto-failover-enterprise-release-checklist-template.md index 85a4c8628..09238c513 100644 --- a/.github/ISSUE_TEMPLATE/pg-auto-failover-enterprise-release-checklist-template.md +++ b/.github/ISSUE_TEMPLATE/pg-auto-failover-enterprise-release-checklist-template.md @@ -7,16 +7,10 @@ assignees: gurkanindibay --- -## Several things to note here - -These instructions assume you have `$VERSION`, `$PROJECT`, and `$REPO` environment variables set in your shell (e.g. `10.0.2`, `citus`, and `citus`). With those set, code from most steps can be copy-pasted. - -**After this checklist, you're still not done: open a release checklist for Enterprise too!** - # Update OS Packages ## Debian and RedHat -- Change your directory to `packaging` repository directory & checkout `all-$PROJECT` branch. -- [ ] Run the pipeline using branch name as all-$PROJECT [update_package_properties workflow](https://github.com/citusdata/packaging/actions/workflows/update_package_properties.yml). Input tag name and if version is fancy, input the fancy version_no. Other parameters could be kept as is if you want +- Change your directory to `packaging` repository directory & checkout `all-pgautofailover-enterprise` branch. +- [ ] Run the pipeline using branch name as all-pgautofailover-enterprise [update_package_properties workflow](https://github.com/citusdata/packaging/actions/workflows/update_package_properties.yml). Input tag name and if version is fancy, input the fancy version_no. Other parameters could be kept as is if you want - Then check the following (needed for both debian & redhat): - [ ] Updated `pkglatest` variable in the `pkgvars` file to `$VERSION.citus-1` - Then check the following (needed for debian): diff --git a/.github/ISSUE_TEMPLATE/pg-auto-failover-release-checklist-template.md b/.github/ISSUE_TEMPLATE/pg-auto-failover-release-checklist-template.md index 3424bfb4d..18095a93e 100644 --- a/.github/ISSUE_TEMPLATE/pg-auto-failover-release-checklist-template.md +++ b/.github/ISSUE_TEMPLATE/pg-auto-failover-release-checklist-template.md @@ -7,16 +7,10 @@ assignees: gurkanindibay --- -## Several things to note here - -These instructions assume you have `$VERSION`, `$PROJECT`, and `$REPO` environment variables set in your shell (e.g. `10.0.2`, `citus`, and `citus`). With those set, code from most steps can be copy-pasted. - -**After this checklist, you're still not done: open a release checklist for Enterprise too!** - # Update OS Packages ## Debian and RedHat -- Change your directory to `packaging` repository directory & checkout `all-$PROJECT` branch. -- [ ] Run the pipeline using branch name as all-project https://github.com/citusdata/packaging/actions/workflows/update_package_properties.yml. Input tag name and if version is fancy, input the fancy version_no. Other parameters could be kept as is if you want +- Change your directory to `packaging` repository directory & checkout `all-pgautofailover` branch. +- [ ] Run the pipeline using branch name as all-pgautofailover [update_package_properties workflow](https://github.com/citusdata/packaging/actions/workflows/update_package_properties.yml). Input tag name and if version is fancy, input the fancy version_no. Other parameters could be kept as is if you want - Then check the following (needed for both debian & redhat): - [ ] Updated `pkglatest` variable in the `pkgvars` file to `$VERSION.citus-1` - Then check the following (needed for debian): From aa2acbb973d1cb73294a3e15cfe7510976a53d5b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?G=C3=BCrkan=20=C4=B0ndibay?= Date: Thu, 25 Nov 2021 09:52:05 +0300 Subject: [PATCH 5/7] Apply suggestions from code review Co-authored-by: Hanefi Onaldi --- ...s-enterprise-release-checklist-template.md | 21 +++++++++---------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/citus-enterprise-release-checklist-template.md b/.github/ISSUE_TEMPLATE/citus-enterprise-release-checklist-template.md index 63674320a..3afa01105 100644 --- a/.github/ISSUE_TEMPLATE/citus-enterprise-release-checklist-template.md +++ b/.github/ISSUE_TEMPLATE/citus-enterprise-release-checklist-template.md @@ -10,13 +10,13 @@ assignees: gurkanindibay # Update OS Packages ## Debian and RedHat - Change your directory to `packaging` repository directory & checkout `all-enterprise` branch. -- [ ] Run the pipeline using branch name as all-enterprise https://github.com/citusdata/packaging/actions/workflows/update_package_properties.yml. Input tag name and if version is fancy, input the fancy version_no. Other parameters could be kept as is if you want +- [ ] Run [this pipeline](https://github.com/citusdata/packaging/actions/workflows/update_package_properties.yml) using branch name as `all-enterprise`. Input tag name and if version is fancy, input the fancy version number. Other parameters could be kept as is if you want. - Then check the following (needed for both debian & redhat): - [ ] Updated `pkglatest` variable in the `pkgvars` file to `$VERSION.citus-1` - Then check the following (needed for debian): - [ ] A new entry (`$VERSION.citus-1`, `stable`) is added to the `debian/changelog` file - Then check the following (needed for redhat): - - [ ] `$PROJECT.spec` file is updated: + - [ ] `citus.spec` file is updated: - [ ] `Version:` field - [ ] `Source0:` field - [ ] A new entry (`$VERSION.citus-1`) in the `%changelog` section @@ -28,14 +28,13 @@ https://github.com/citusdata/tools/blob/be12af3b8f435d17a52e607c666f6b15379f5970 ## Microsoft Packages - [ ] Add vso (Visual Studio Online) remote to your local git checkout of the github packaging repo (only needed once): -`git remote add vso msdata@vs-ssh.visualstudio.com:v3/msdata/Database%20Systems/citus-packaging` + `git remote add vso msdata@vs-ssh.visualstudio.com:v3/msdata/Database%20Systems/citus-packaging` - [ ] To trigger a test build on Azure DevOps: `git checkout all-enterprise` `git pull # from normal github origin` `git push vso # update Azure DevOps mirror` -- [ ] Go here: https://msdata.visualstudio.com/Database%20Systems/_build?definitionId=10018&_a=summary -- [ ] Wait for build to succeed. If build does not success, go here: -https://msdata.visualstudio.com/Database%20Systems/_apps/hub/ms.vss-ciworkflow.build-ci-hub?_a=edit-build-definition&id=10018. +- [ ] Open [ADO pipeline page](https://msdata.visualstudio.com/Database%20Systems/_build?definitionId=10018&_a=summary) +- [ ] Wait for build to succeed. If build does not success, go [here](https://msdata.visualstudio.com/Database%20Systems/_apps/hub/ms.vss-ciworkflow.build-ci-hub?_a=edit-build-definition&id=10018) Maybe you need to update some parameters there (like the tools repo version). Then save it without queuing and then “Run pipeline” again via the first link. - [ ] Check that it created the right packages by looking at the logs and artifacts (the button with the box/drawer icon and text “8 published”). - [ ] Click there, and see 7 items in signed packages @@ -46,11 +45,11 @@ Maybe you need to update some parameters there (like the tools repo version). Th - [ ] Go back to the overview: https://msdata.visualstudio.com/Database%20Systems/_build?definitionId=10018&_a=summary - [ ] Click “Run pipeline” - [ ] Click “Variables” -- [ ] Change PUBLISH_TO_PACKAGE_REPO to “true” +- [ ] Change `PUBLISH_TO_PACKAGE_REPO` to “true” - [ ] Go back after doing so and click "Run” - [ ] Wait until completed. - [ ] Check if packages are successfully published using below links: - - [ ] 6 new items for the version for Ubuntu (xenial , bionic and focal): https://packages.microsoft.com/repos/citus-ubuntu/pool/main/c/citus-enterprise/ - - [ ] 4 new items for the version for Debian (buster and stretch): https://packages.microsoft.com/repos/citus-debian/pool/main/c/citus-enterprise/ ( for release >9.4 and < 9.5, 4 package is expected. Since 9.5 6 package is expected) - - [ ] 2 new items for the version for CentOS7/RHEL7: https://packages.microsoft.com/yumrepos/citus-centos7/ - - [ ] 2 new items for the version for CentOS8/RHEL8: https://packages.microsoft.com/yumrepos/citus-centos8/ + - [ ] 6 new items for the version for Ubuntu (xenial , bionic and focal): [here](https://packages.microsoft.com/repos/citus-ubuntu/pool/main/c/citus-enterprise/) + - [ ] 4 new items for the version for Debian (buster and stretch): [here](https://packages.microsoft.com/repos/citus-debian/pool/main/c/citus-enterprise/) ( for release >9.4 and < 9.5, 4 package is expected. Since 9.5 6 package is expected) + - [ ] 2 new items for the version for CentOS7/RHEL7: [here](https://packages.microsoft.com/yumrepos/citus-centos7/) + - [ ] 2 new items for the version for CentOS8/RHEL8: [here](https://packages.microsoft.com/yumrepos/citus-centos8/) From 809948c76c89d3dc072c570e50564581311767ea Mon Sep 17 00:00:00 2001 From: gindibay Date: Thu, 25 Nov 2021 11:12:53 +0300 Subject: [PATCH 6/7] Revert "Removes output validation" This reverts commit 8440ee47dde94cf122dc3ccf3ae9f50dfed51f31. --- .github/workflows/build-citus-community-nightlies.yml | 3 ++- .github/workflows/build-citus-enterprise-nightlies.yml | 3 ++- .github/workflows/build-pgaf-enterprise-nightlies.yml | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-citus-community-nightlies.yml b/.github/workflows/build-citus-community-nightlies.yml index d2803db19..65882449e 100644 --- a/.github/workflows/build-citus-community-nightlies.yml +++ b/.github/workflows/build-citus-community-nightlies.yml @@ -66,7 +66,8 @@ jobs: --secret_key "${PACKAGING_SECRET_KEY}" \ --passphrase "${PACKAGING_PASSPHRASE}" \ --output_dir "$(pwd)/packages/" \ - --input_files_dir "$(pwd)/packaging" + --input_files_dir "$(pwd)/packaging" \ + --output_validation - name: Publish packages run: | diff --git a/.github/workflows/build-citus-enterprise-nightlies.yml b/.github/workflows/build-citus-enterprise-nightlies.yml index b1026f593..d4864313c 100644 --- a/.github/workflows/build-citus-enterprise-nightlies.yml +++ b/.github/workflows/build-citus-enterprise-nightlies.yml @@ -67,7 +67,8 @@ jobs: --secret_key "${PACKAGING_SECRET_KEY}" \ --passphrase "${PACKAGING_PASSPHRASE}" \ --output_dir "$(pwd)/packages/" \ - --input_files_dir "$(pwd)/packaging" + --input_files_dir "$(pwd)/packaging" \ + --output_validation - name: Publish packages run: | diff --git a/.github/workflows/build-pgaf-enterprise-nightlies.yml b/.github/workflows/build-pgaf-enterprise-nightlies.yml index d88bea21a..170674c58 100644 --- a/.github/workflows/build-pgaf-enterprise-nightlies.yml +++ b/.github/workflows/build-pgaf-enterprise-nightlies.yml @@ -67,7 +67,8 @@ jobs: --secret_key "${PACKAGING_SECRET_KEY}" \ --passphrase "${PACKAGING_PASSPHRASE}" \ --output_dir "$(pwd)/packages/" \ - --input_files_dir "$(pwd)/packaging" + --input_files_dir "$(pwd)/packaging" \ + --output_validation - name: Publish packages run: | From 0fb8246cf919296c25126233161d3ec1dbfec7c0 Mon Sep 17 00:00:00 2001 From: gindibay Date: Thu, 25 Nov 2021 11:45:35 +0300 Subject: [PATCH 7/7] Fixes review comments --- ...r-enterprise-release-checklist-template.md | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/pg-auto-failover-enterprise-release-checklist-template.md b/.github/ISSUE_TEMPLATE/pg-auto-failover-enterprise-release-checklist-template.md index 09238c513..3f2d2e69b 100644 --- a/.github/ISSUE_TEMPLATE/pg-auto-failover-enterprise-release-checklist-template.md +++ b/.github/ISSUE_TEMPLATE/pg-auto-failover-enterprise-release-checklist-template.md @@ -21,9 +21,9 @@ assignees: gurkanindibay - [ ] `Source0:` field - [ ] A new entry (`$VERSION.citus-1`) in the `%changelog` section - [ ] Get changes reviewed; merge the PR -- [ ] Ensure Github Actions builds completed successfully and package count for each os is as below table and packages in postgres versions is compliant with `postgres-matrix.yml` in the `all-project` branch +- [ ] Ensure Github Actions builds completed successfully and package count for each os is as table in the [link](https://github.com/citusdata/tools/blob/be12af3b8f435d17a52e607c666f6b15379f5970/packaging_automation/tests/test_citus_package.py#L21-L33) and packages in postgres versions is compliant with `postgres-matrix.yml` in the `all-project` branch + -https://github.com/citusdata/tools/blob/be12af3b8f435d17a52e607c666f6b15379f5970/packaging_automation/tests/test_citus_package.py#L21-L33 ## Microsoft Packages @@ -33,24 +33,24 @@ https://github.com/citusdata/tools/blob/be12af3b8f435d17a52e607c666f6b15379f5970 `git checkout all-pgautofailover-enterprise` `git pull # from normal github origin` `git push vso # update Azure DevOps mirror` -- [ ] Go here: https://msdata.visualstudio.com/Database%20Systems/_build?definitionId=10018&_a=summary -- [ ] Wait for build to succeed. If build does not success, go here: -https://msdata.visualstudio.com/Database%20Systems/_apps/hub/ms.vss-ciworkflow.build-ci-hub?_a=edit-build-definition&id=10018. -Maybe you need to update some parameters there (like the tools repo version). Then save it without queuing and then “Run pipeline” again via the first link. +- [ ] [Go here:](https://msdata.visualstudio.com/Database%20Systems/_build?definitionId=10018&_a=summary) +- [ ] Wait for build to succeed. If build does not success, go [here:](https://msdata.visualstudio.com/Database%20Systems/_apps/hub/ms.vss-ciworkflow.build-ci-hub?_a=edit-build-definition&id=10018.) + + Maybe you need to update some parameters there (like the tools repo version). Then save it without queuing and then “Run pipeline” again via the first link. - [ ] Check that it created the right packages by looking at the logs and artifacts (the button with the box/drawer icon and text “8 published”). - [ ] Click there, and see 7 items in signed packages centos 6/7/8 debian buster/stretch ubuntu bionic/xenial - [ ] Check logs for each of 7 builds, by clicking `View raw log` -- [ ] Go back to the overview: https://msdata.visualstudio.com/Database%20Systems/_build?definitionId=10018&_a=summary +- [ ] Go back to the [overview:](https://msdata.visualstudio.com/Database%20Systems/_build?definitionId=10018&_a=summary) - [ ] Click “Run pipeline” - [ ] Click “Variables” - [ ] Change PUBLISH_TO_PACKAGE_REPO to “true” - [ ] Go back after doing so and click "Run” - [ ] Wait until completed. - [ ] Check if packages are successfully published using below links: - - [ ] 6 new items for the version for Ubuntu (xenial , bionic and focal): https://packages.microsoft.com/repos/citus-ubuntu/pool/main/c/citus-enterprise/ - - [ ] 4 new items for the version for Debian (buster and stretch): https://packages.microsoft.com/repos/citus-debian/pool/main/c/citus-enterprise/ ( for release >9.4 and < 9.5, 4 package is expected. Since 9.5 6 package is expected) - - [ ] 2 new items for the version for CentOS7/RHEL7: https://packages.microsoft.com/yumrepos/citus-centos7/ - - [ ] 2 new items for the version for CentOS8/RHEL8: https://packages.microsoft.com/yumrepos/citus-centos8/ + - [ ] 6 new items for the version for Ubuntu [(xenial , bionic and focal):](https://packages.microsoft.com/repos/citus-ubuntu/pool/main/c/citus-enterprise/) + - [ ] 4 new items for the version for Debian [(buster and stretch):](https://packages.microsoft.com/repos/citus-debian/pool/main/c/citus-enterprise/ ( for release >9.4 and < 9.5, 4 package is expected. Since 9.5 6 package is expected)) + - [ ] 2 new items for the version for [CentOS7/RHEL7: ](https://packages.microsoft.com/yumrepos/citus-centos7/) + - [ ] 2 new items for the version for [CentOS8/RHEL8:](https://packages.microsoft.com/yumrepos/citus-centos8/)