Skip to content

Last Commit #68

@giosce

Description

@giosce

I still see something not working 100% after @themightychris and I made a change to get the last_commit on the default branch not from Bot.

ProjectIndex shows these 2 as updated in a week:
https://github.com/BetaNYC/batch-geocoder-nyc/branches
https://github.com/18F/10x-MLaaS/branches

This is the API call for the F18 project https://api.github.com/repos/18F/10x-MLaaS/commits
I don't see a commit with date within last week in response, regardless of committer name/type. The code checks for author.type != 'Bot' and uses author.date so the code seems correct to me.

The 18F project toml has been updated recently (so there isn't a problem of not updating the toml files).

The code trying to get the last_commit is at https://github.com/codeforamerica/brigade-project-index/blob/master/crawler/lib/decorators/GitHubLastCommit.js

Actually, the snapshot is fine (has 2021 date commit) https://github.com/codeforamerica/brigade-project-index/blob/snapshot/v1/projects/18F/10x-MLaaS.toml, the "index" is wrong (saying within last week) https://github.com/codeforamerica/brigade-project-index/blob/index/v1/projects/18F/10x-MLaaS.toml

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    New Issue Review

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions