Skip to content

Commit 1c17600

Browse files
chore: bump @ckb-ccc/core to 1.14.0 to fix ws vulnerability (#436)
* chore: bump @ckb-ccc/core to 1.14.0 to fix ws vulnerability Upgrades @ckb-ccc/core from 1.5.3 to 1.14.0 so the transitive ws dependency resolves to ^8.21.0, which patches the reported memory exhaustion DoS advisory. * fix: add NervosDao to devnet known scripts for ccc 1.14.0 compatibility ccc >= 1.14.0 calls getKnownScript(NervosDao) during completeFeeBy for every input. Devnet has no NervosDao deployment, so supplying the testnet definition lets isNervosDao() return false without throwing. Also add the missing changeset for the @ckb-ccc/core bump. Co-Authored-By: Claude <noreply@anthropic.com> * ci: skip changeset PR comments on fork PRs The github-script comment steps require pull-requests: write, which fork PRs do not receive with the pull_request trigger. Skip the optional comment steps on forks so the required changeset check can still pass/fail cleanly. Co-Authored-By: Claude <noreply@anthropic.com> * fix: use actual devnet DAO script for NervosDao known script The previous fallback reused the testnet NervosDao definition. Devnet deploys its own DAO system cell, so map KnownScript.NervosDao to the devnet dao script derived from ckb list-hashes instead. Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
1 parent 82dfd37 commit 1c17600

5 files changed

Lines changed: 65 additions & 397 deletions

File tree

.changeset/bump-ccc-core-ws-fix.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@offckb/cli": patch
3+
---
4+
5+
Bump @ckb-ccc/core to 1.14.0 to fix the ws vulnerability (ws >= 8.21.0).

.github/workflows/changeset-check.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ jobs:
4444
fi
4545
4646
- name: Comment on PR (success)
47-
if: steps.check.outputs.has_changeset == 'true'
47+
if: steps.check.outputs.has_changeset == 'true' && !github.event.pull_request.head.repo.fork
4848
uses: actions/github-script@v7
4949
with:
5050
script: |
@@ -68,7 +68,7 @@ jobs:
6868
}
6969
7070
- name: Comment on PR (failure)
71-
if: failure()
71+
if: failure() && !github.event.pull_request.head.repo.fork
7272
uses: actions/github-script@v7
7373
with:
7474
script: |

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
"typescript": "^5.3.3"
7979
},
8080
"dependencies": {
81-
"@ckb-ccc/core": "1.5.3",
81+
"@ckb-ccc/core": "1.14.0",
8282
"@iarna/toml": "^2.2.5",
8383
"@inquirer/prompts": "^7.8.6",
8484
"@types/http-proxy": "^1.17.15",

0 commit comments

Comments
 (0)