Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downcast converters for bookmark #17876

Open
NavinShrinivas opened this issue Feb 4, 2025 · 0 comments
Open

Downcast converters for bookmark #17876

NavinShrinivas opened this issue Feb 4, 2025 · 0 comments
Labels
type:bug This issue reports a buggy (incorrect) behavior.

Comments

@NavinShrinivas
Copy link

πŸ“ Provide detailed reproduction steps (if any)

  1. Create a downcast converter plugin for bookmar
  2. add a bookmark
  3. view the HTML from ckeditor inspector

βœ”οΈ Expected result

To stick to what the downcast converter is supposed to do

❌ Actual result

Nothing happens, bookmark continues to be what it was being

❓ Possible solution

If you have ideas, you can list them here. Otherwise, you can delete this section.

πŸ“ƒ Other details

  • Browser: Chrome
  • OS: MacOS 15.1
  • First affected CKEditor version: angular npm version
  • Installed CKEditor plugins: bookmark, classic-build

this is the following code for the converter :

 this.editor.conversion.for('downcast').elementToStructure({
      model: 'bookmark',
      view: (modelElement, { writer }) => {
          const element = writer.createContainerElement('span', {
              class: 'bookmark', 
          }, [
            writer.createSlot()
          ]);
          return element;
      }
  });

This converter takes effect, for say heading1 but does not for bookmarks. So I'm certain this issue is with bookmarks only.

@NavinShrinivas NavinShrinivas added the type:bug This issue reports a buggy (incorrect) behavior. label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

1 participant