Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the license for the emoji JSON file hosted on the CDN #17933

Open
cbrandtbuffalo opened this issue Feb 14, 2025 · 3 comments
Open

Clarify the license for the emoji JSON file hosted on the CDN #17933

cbrandtbuffalo opened this issue Feb 14, 2025 · 3 comments
Labels
domain:integration-dx This issue reports a problem with the developer experience when integrating CKEditor into a system. package:emoji pending:feedback This issue is blocked by necessary feedback. type:docs This issue reports a task related to documentation (e.g. an idea for a guide).

Comments

@cbrandtbuffalo
Copy link

📝 Provide a description of requested docs changes

What is the purpose and what should be changed?

The new emoji plugin pulls emoji definitions from the ckeditor CDN by default. The URL to use when fetching emoji definitions is configurable, so the JSON file could be hosted elsewhere.

Is there a license on the en.json file hosted on the CDN that indicates how it can be used? I don't see the file itself in the ckeditor5 repo in github.

@cbrandtbuffalo cbrandtbuffalo added the type:docs This issue reports a task related to documentation (e.g. an idea for a guide). label Feb 14, 2025
@Witoso
Copy link
Member

Witoso commented Feb 20, 2025

Apologies for the late response!

This file is part of CKEditor 5 distribution and should be treated as such. You can find the licensing information in https://github.com/ckeditor/ckeditor5/blob/master/LICENSE.md

@Witoso Witoso added pending:feedback This issue is blocked by necessary feedback. domain:integration-dx This issue reports a problem with the developer experience when integrating CKEditor into a system. package:emoji labels Feb 20, 2025
@cbrandtbuffalo
Copy link
Author

Ah, and the license also notes that emojibase-data is included under the MIT license:
emojibase-data - Copyright (c) 2017-2019 Miles Johnson.

@Witoso
Copy link
Member

Witoso commented Feb 20, 2025

The file we host was built for CKEditor 5 purposes (using this dependency), and therefore we recommend thinking about it as about any other dependencies of CKEditor 5 which are integral parts of its distribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:integration-dx This issue reports a problem with the developer experience when integrating CKEditor into a system. package:emoji pending:feedback This issue is blocked by necessary feedback. type:docs This issue reports a task related to documentation (e.g. an idea for a guide).
Projects
None yet
Development

No branches or pull requests

2 participants