Skip to content

Commit fb8b123

Browse files
authored
Merge branch 'master' into qt/fix_scroll
2 parents 961d890 + 827356c commit fb8b123

File tree

5 files changed

+32
-7
lines changed

5 files changed

+32
-7
lines changed

src/components/Navigation/Pages/PageBrowse/PageBrowse.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@ class PageBrowse extends SystemManagedList {
3434
this.state = {
3535
activeSort: 'releaseDate-desc',
3636
searchFocused: false,
37-
selectedProvider: providers[0]
37+
selectedProvider: providers[0],
38+
searchTerm: ''
3839
}
3940
this.onFilter = this.onFilter.bind(this)
4041
this.onSort = this.onSort.bind(this)
@@ -63,13 +64,19 @@ class PageBrowse extends SystemManagedList {
6364
}
6465

6566
onBrowse = value => {
66-
this.setState({ activeName: value }, () => this.updateData())
67+
this.setState({ activeName: value, searchTerm: '' }, () => this.updateData())
6768
}
6869

6970
onFocusChange = value => {
7071
this.setState({ searchFocused: value })
7172
}
7273

74+
onSearch = value => {
75+
this.setState({ searchTerm: value })
76+
const provider = this.state.selectedProvider.value
77+
super.onSearch(provider + '/' + value)
78+
}
79+
7380
tableTitle() {
7481
return 'Browse'
7582
}
@@ -163,6 +170,7 @@ class PageBrowse extends SystemManagedList {
163170

164171
onProviderChange(item) {
165172
this.setState({ selectedProvider: item })
173+
this.state.searchTerm && super.onSearch(item.value + '/' + this.state.searchTerm)
166174
}
167175

168176
// Overrides the default onFilter method

src/components/Navigation/Pages/PageDefinitions/ButtonsBar.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@ import ButtonWithTooltip from '../../Ui/ButtonWithTooltip'
55
import ShareButton from '../../Ui/ShareButton'
66

77
export default class ButtonsBar extends Component {
8+
constructor(props) {
9+
super(props)
10+
this.onSelect = this.onSelect.bind(this)
11+
}
12+
813
static propTypes = {
914
components: PropTypes.object,
1015
hasChanges: PropTypes.bool,

src/components/Navigation/Ui/ShareButton.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,18 @@ export default class ShareButton extends Component {
1313
const disabled = !components || components.list.length === 0
1414
return (
1515
<DropdownButton disabled={disabled} id={'sharedropdown'} title="Share" bsStyle="success">
16-
<MenuItem eventKey="1" onSelect={() => onSelect('url')}>
16+
<MenuItem eventKey="1" className="dropdown-item" onSelect={() => onSelect('url')}>
1717
URL
1818
</MenuItem>
19-
<MenuItem eventKey="2" onSelect={() => onSelect('file')}>
19+
<MenuItem eventKey="2" className="dropdown-item" onSelect={() => onSelect('file')}>
2020
Coordinate list (JSON)
2121
</MenuItem>
22-
<MenuItem eventKey="2" onSelect={() => onSelect('notice')}>
22+
<MenuItem eventKey="2" className="dropdown-item" onSelect={() => onSelect('notice')}>
2323
Notice file
2424
</MenuItem>
25-
<MenuItem divider />
25+
{/* <MenuItem divider />
2626
<MenuItem disabled>Definitions (Not implemented)</MenuItem>
27-
<MenuItem disabled>SPDX (Not implemented)</MenuItem>
27+
<MenuItem disabled>SPDX (Not implemented)</MenuItem> */}
2828
</DropdownButton>
2929
)
3030
}

src/styles/_ShareButton.scss

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
.open > .dropdown-menu {
2+
display: block;
3+
}
4+
5+
.dropdown.btn-group {
6+
display: inline-block;
7+
}
8+
9+
.dropdown-item > a {
10+
display: block;
11+
}

src/styles/index.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,5 +75,6 @@ main {
7575
@import './GetInvolved.scss';
7676
@import './PageAbout.scss';
7777
@import './charter.scss';
78+
@import './ShareButton.scss';
7879

7980
@import './utils.scss';

0 commit comments

Comments
 (0)