#148 Fix services prefix using cleverage_process instead of process_bundle

Author: njoubert-cleverage

CHANGELOG.md

@@ -11,13 +11,15 @@ v4.0
 * [#142](https://github.com/cleverage/process-bundle/issues/142) ExplodeTransformer, HashTransformer, ImplodeTransformer, SlugifyTransformer, SprintfTransformer & TrimTransformer namespaces changed to `CleverAge\ProcessBundle\Transformer\String`
 * [#142](https://github.com/cleverage/process-bundle/issues/142) InstantiateTransformer, PropertyAccessorTransformer RecursivePropertySetterTransformer namespaces changed to `CleverAge\ProcessBundle\Transformer\Object`
 * [#147](https://github.com/cleverage/process-bundle/issues/147) Replace `Symfony\Component\Form\Exception\InvalidConfigurationException` by `Symfony\Component\Config\Definition\Exception\InvalidConfigurationException`
-
+* [#148](https://github.com/cleverage/process-bundle/issues/148) Update services (step 1) according to Symfony best practices. Services should not use autowiring or autoconfiguration. Instead, all services should be defined explicitly. 
+Services must be prefixed with the bundle alias instead of using fully qualified class names => `cleverage_process`
 ### Changes
 
 * [#139](https://github.com/cleverage/process-bundle/issues/139Update) Makefile & .docker for local standalone usage
 * [#139](https://github.com/cleverage/process-bundle/issues/139Update) Update rector, phpstan & php-cs-fixer configurations & apply it
 * [#141](https://github.com/cleverage/process-bundle/issues/141) `league/flysystem-bundle` is not required anymore
 * [#130](https://github.com/cleverage/process-bundle/issues/130) EventDispatcherInterface service declaration breaks dependency injection
+* [#147](https://github.com/cleverage/process-bundle/issues/147) Add missing dependencies on `symfony/dotenv` and `symfony/runtime`
 * [#147](https://github.com/cleverage/process-bundle/issues/147) Remove dependencies on `symfony/form`, `symfony/messenger` & `symfony/scheduler` 
 
 ### Fixes

config/services/command.yaml

@@ -5,23 +5,23 @@ services:
         tags:
             - { name: console.command }
         arguments:
-            - '@process_bundle.manager.process'
+            - '@cleverage_process.manager.process'
             - '@event_dispatcher'
-            - '@process_bundle.registry.process_configuration'
+            - '@cleverage_process.registry.process_configuration'
 
     cleverage_process.command.list_process:
         class: CleverAge\ProcessBundle\Command\ListProcessCommand
         public: false
         tags:
             - { name: console.command }
         arguments:
-            - '@process_bundle.registry.process_configuration'
+            - '@cleverage_process.registry.process_configuration'
 
     cleverage_process.command.process_help:
         class: CleverAge\ProcessBundle\Command\ProcessHelpCommand
         public: false
         tags:
             - { name: console.command }
         arguments:
-            - '@process_bundle.registry.process_configuration'
+            - '@cleverage_process.registry.process_configuration'
             - '@service_container'

config/services/logger.yaml

@@ -5,23 +5,23 @@ services:
         tags:
             - { name: monolog.processor, channel: cleverage_process }
         arguments:
-            - '@process_bundle.manager.process'
+            - '@cleverage_process.manager.process'
 
     cleverage_process.logger.task_processor:
         class: CleverAge\ProcessBundle\Logger\TaskProcessor
         public: false
         tags:
             - { name: monolog.processor, channel: cleverage_process_task }
         arguments:
-            - '@process_bundle.manager.process'
+            - '@cleverage_process.manager.process'
 
     cleverage_process.logger.transformer_processor:
         class: CleverAge\ProcessBundle\Logger\TransformerProcessor
         public: false
         tags:
             - { name: monolog.processor, channel: cleverage_process_transformer }
         arguments:
-            - '@process_bundle.manager.process'
+            - '@cleverage_process.manager.process'
 
     cleverage_process.logger.process_logger:
         class: CleverAge\ProcessBundle\Logger\ProcessLogger

config/services/manager.yaml

@@ -1,15 +1,15 @@
 services:
-    process_bundle.manager.process:
+    cleverage_process.manager.process:
         class: CleverAge\ProcessBundle\Manager\ProcessManager
         public: false
         arguments:
             - '@service_container'
             - '@cleverage_process.logger.process_logger'
             - '@cleverage_process.logger.task_logger'
-            - '@process_bundle.registry.process_configuration'
-            - '@process_bundle.context.contextual_option_resolver'
+            - '@cleverage_process.registry.process_configuration'
+            - '@cleverage_process.context.contextual_option_resolver'
             - '@event_dispatcher'
 
-    process_bundle.context.contextual_option_resolver:
+    cleverage_process.context.contextual_option_resolver:
         class: CleverAge\ProcessBundle\Context\ContextualOptionResolver
         public: false

config/services/registry.yaml

@@ -1,11 +1,11 @@
 services:
-    process_bundle.registry.process_configuration:
+    cleverage_process.registry.process_configuration:
         class: CleverAge\ProcessBundle\Registry\ProcessConfigurationRegistry
         public: false
         arguments:
             - ~
             - ~
 
-    process_bundle.registry.transformer:
+    cleverage_process.registry.transformer:
         class: CleverAge\ProcessBundle\Registry\TransformerRegistry
         public: false

config/services/task.yaml

@@ -1,9 +1,9 @@
 services:
     _defaults:
         bind:
-            $processManager: '@process_bundle.manager.process'
-            $processRegistry: '@process_bundle.registry.process_configuration'
-            $transformerRegistry: '@process_bundle.registry.transformer'
+            $processManager: '@cleverage_process.manager.process'
+            $processRegistry: '@cleverage_process.registry.process_configuration'
+            $transformerRegistry: '@cleverage_process.registry.transformer'
 
     CleverAge\ProcessBundle\Task\:
         resource: '../../src/Task/*'

config/services/transformer.yaml

@@ -2,7 +2,7 @@ services:
     _defaults:
         bind:
             $language: '@cleverage_process.expression_language'
-            $transformerRegistry: '@process_bundle.registry.transformer'
+            $transformerRegistry: '@cleverage_process.registry.transformer'
 
     CleverAge\ProcessBundle\Transformer\:
         resource: '../../src/Transformer/*'

src/DependencyInjection/CleverAgeProcessExtension.php

@@ -13,7 +13,6 @@
 
 namespace CleverAge\ProcessBundle\DependencyInjection;
 
-use CleverAge\ProcessBundle\Registry\ProcessConfigurationRegistry;
 use CleverAge\ProcessBundle\Transformer\GenericTransformer;
 use Symfony\Component\Config\FileLocator;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
@@ -37,7 +36,7 @@ public function load(array $configs, ContainerBuilder $container): void
         $configuration = new Configuration();
         $config = $this->processConfiguration($configuration, $configs);
 
-        $processConfigurationRegistry = $container->getDefinition('process_bundle.registry.process_configuration');
+        $processConfigurationRegistry = $container->getDefinition('cleverage_process.registry.process_configuration');
         $processConfigurationRegistry->replaceArgument(0, $config['configurations']);
         $processConfigurationRegistry->replaceArgument(1, $config['default_error_strategy']);