Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events on each task execution ? #112

Open
4 tasks
shavounet opened this issue Feb 19, 2020 · 1 comment
Open
4 tasks

Events on each task execution ? #112

shavounet opened this issue Feb 19, 2020 · 1 comment

Comments

@shavounet
Copy link
Contributor

Description

  • Pro :
    • allow for custom watchers on task execution without interfering with pure process definition
  • Cons :
    • might be a huge perf bottleneck, esp. for slow listeners

Requirements

  • Documentation updates
    • Reference
    • Cookbooks
    • Changelog
  • Unit tests

Breaking changes

@shavounet
Copy link
Contributor Author

shavounet commented Feb 19, 2020

After a small local bench, it represents between 2µs and 5µs per dispatch with only one very simple listener (ignoring listener execution time).

But we need to be careful with sf4 Interface change for the EventDispatcher => trigger_error car blow up execution time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant