-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweaking the level of the log of a succeeded process #157
Comments
In my opinion if the client only wants to see the errors for his scheduled process then it means the command line in the cron (or other scheduler) should contains the --quiet (-q) flag: |
@VincentChalnot In this instance, the presence of an INFO log would mean that at least one file was treated by the task. This is why they asked us to remove this specific log because "info: 1" means 0 files treated et "info: 2" means 1 file treated. |
The ProcessManager is not aware of what happens in each task right? Alltough I agree with you that this kind of message could be configured with a custom task according to the need of the process. |
One proposed solution would be to be able to configure the level of the messages of the bundle (info or debug). |
Seems like a good compromise but adds complexity. I would advise to deprecate this and force the message as debug for the next big release. |
On my mind, there are 2 differents informations :
|
A client asked us to remove the message logged when the process is finished.
process-bundle/src/Manager/ProcessManager.php
Lines 514 to 519 in b520cdb
The reasoning is that when you schedule a import task every hour, chances are that there are no file to import. However, there is still an "INFO" displayed even though the task technically did not do anything at all of value.
The idea would be to downgrade the log to DEBUG so that the presence or not of logs in the reports columns would mean something.
WDYT?
The text was updated successfully, but these errors were encountered: