Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the FileReaderTasks to abstract the input file type #78

Open
2 tasks
shavounet opened this issue Nov 14, 2019 · 0 comments
Open
2 tasks

Refactor the FileReaderTasks to abstract the input file type #78

shavounet opened this issue Nov 14, 2019 · 0 comments
Assignees

Comments

@shavounet
Copy link
Contributor

shavounet commented Nov 14, 2019

Feature description

  • ease the definition of new file type that can be read/written
    • old interface are not flexible enough for all use cases
  • add a new XMLReaderTask

Implementation proposal

  • new namespace File (maybe one day, a separate bundle & ditch the old interfaces ?)
  • based on SplFileObject ?
  • separate File manipulation and Resource manipulation using composition instead of inheritance
  • interfaces : readable / writable / readableStream / writableStream / seekable ?
  • file types : csv / json / json_stream / xml
  • test compaibility with flysystem ?

PR requirements

  • Documentation
  • Unit tests
  • Breaking changes : yes (minor, on FileInterface ? add a new interface & depreciate the old one ?)
@shavounet shavounet self-assigned this Nov 14, 2019
@shavounet shavounet added this to the v3.1 milestone Nov 14, 2019
@shavounet shavounet modified the milestones: v3.1.0, v3.1.1 Feb 12, 2020
@shavounet shavounet modified the milestones: v3.1.1, v3.3 Sep 17, 2021
@xaviermarchegay xaviermarchegay removed this from the v3.3 milestone Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants