#4 Update services according to Symfony best practices. Services should not use autowiring or autoconfiguration. Instead, all services should be defined explicitly. Services must be prefixed with the bundle alias instead of using fully qualified class names => cleverage_soap_process

Author: njoubert-cleverage

CHANGELOG.md

@@ -3,6 +3,11 @@ v2.0
 
 ## BC breaks
 
+* [#4](https://github.com/cleverage/soap-process-bundle/issues/4) Update services according to Symfony best practices.
+Services should not use autowiring or autoconfiguration. Instead, all services should be defined explicitly.
+Services must be prefixed with the bundle alias instead of using fully qualified class names => `cleverage_soap_process`
+
+
 ### Changes
 
 * [#2](https://github.com/cleverage/soap-process-bundle/issues/2) Add Makefile & .docker for local standalone usage

config/services/registry.yaml

@@ -0,0 +1,4 @@
+services:
+    cleverage_soap_process.registry.client:
+        class: CleverAge\SoapProcessBundle\Registry\ClientRegistry
+        public: false

config/services/task.yaml

@@ -0,0 +1,9 @@
+services:
+    cleverage_soap_process.task.request:
+        class: CleverAge\SoapProcessBundle\Task\RequestTask
+        public: false
+        arguments:
+            - '@monolog.logger'
+            - '@cleverage_soap_process.registry.client'
+        tags:
+            - { name: monolog.logger, channel: cleverage_process_task }

config/services/transformer.yaml

@@ -0,0 +1,9 @@
+services:
+    cleverage_soap_process.transformer.request:
+        class: CleverAge\SoapProcessBundle\Transformer\RequestTransformer
+        public: false
+        arguments:
+            - '@cleverage_soap_process.registry.client'
+        tags:
+            - { name: cleverage.transformer }
+            - { name: monolog.logger, channel: cleverage_process_transformer }

src/CleverAgeSoapProcessBundle.php

@@ -18,13 +18,6 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\HttpKernel\Bundle\Bundle;
 
-/**
- * Class CleverAgeSoapProcessBundle.
- *
- * @author  Valentin Clavreul <[email protected]>
- * @author  Vincent Chalnot <[email protected]>
- * @author  Madeline Veyrenc <[email protected]>
- */
 class CleverAgeSoapProcessBundle extends Bundle
 {
     /**
@@ -40,4 +33,9 @@ public function build(ContainerBuilder $container): void
             )
         );
     }
+
+    public function getPath(): string
+    {
+        return \dirname(__DIR__);
+    }
 }

src/DependencyInjection/CleverAgeSoapProcessExtension.php

@@ -28,7 +28,7 @@ class CleverAgeSoapProcessExtension extends Extension
 {
     public function load(array $configs, ContainerBuilder $container): void
     {
-        $this->findServices($container, __DIR__.'/../Resources/config/services');
+        $this->findServices($container, __DIR__.'/../../config/services');
     }
 
     /**