Merge pull request #15 from cleverage/14_quality

#14 Quality fix

Author: tonongregory

phpstan.neon

@@ -1,5 +1,5 @@
 parameters:
-    level: 8
+    level: 6
     paths:
         - src
         - tests
@@ -14,7 +14,10 @@ parameters:
         - '#process\(\) has no return type specified#'
         - '#should return Iterator but returns Traversable#'
         - '#Negated boolean expression is always false#'
-    checkGenericClassInNonGenericObjectType: false
+        -
+            identifier: missingType.generics
+        -
+            identifier: doctrine.columnType
     reportUnmatchedIgnoredErrors: false
     inferPrivatePropertyTypeFromConstructor: true
     treatPhpDocTypesAsCertain: false

src/Entity/LogRecord.php

@@ -51,7 +51,7 @@ public function getId(): ?int
     public function __construct(
         \Monolog\LogRecord $record,
         #[ORM\ManyToOne(targetEntity: ProcessExecution::class, cascade: ['all'])]
-        #[ORM\JoinColumn(name: 'process_execution_id', referencedColumnName: 'id', onDelete: 'CASCADE')]
+        #[ORM\JoinColumn(name: 'process_execution_id', referencedColumnName: 'id', onDelete: 'CASCADE', nullable: false)]
         private readonly ProcessExecution $processExecution,
     ) {
         $this->channel = (string) (new UnicodeString($record->channel))->truncate(64);

src/Repository/ProcessExecutionRepository.php

@@ -22,9 +22,9 @@
  * @extends EntityRepository<ProcessExecution>
  *
  * @method ProcessExecution|null find($id, $lockMode = null, $lockVersion = null)
- * @method ProcessExecution|null findOneBy(array $criteria, array $orderBy = null)
+ * @method ProcessExecution|null findOneBy(mixed[] $criteria, string[] $orderBy = null)
  * @method ProcessExecution[]    findAll()
- * @method ProcessExecution[]    findBy(array $criteria, array $orderBy = null, $limit = null, $offset = null)
+ * @method ProcessExecution[]    findBy(mixed[] $criteria, string[] $orderBy = null, $limit = null, $offset = null)
  */
 class ProcessExecutionRepository extends EntityRepository
 {

src/Repository/ProcessScheduleRepository.php

@@ -21,9 +21,9 @@
  * @extends ServiceEntityRepository<ProcessSchedule>
  *
  * @method ProcessSchedule|null find($id, $lockMode = null, $lockVersion = null)
- * @method ProcessSchedule|null findOneBy(array $criteria, array $orderBy = null)
+ * @method ProcessSchedule|null findOneBy(mixed[] $criteria, string[] $orderBy = null)
  * @method ProcessSchedule[]    findAll()
- * @method ProcessSchedule[]    findBy(array $criteria, array $orderBy = null, $limit = null, $offset = null)
+ * @method ProcessSchedule[]    findBy(mixed[] $criteria, string[] $orderBy = null, $limit = null, $offset = null)
  */
 class ProcessScheduleRepository extends ServiceEntityRepository
 {