Skip to content

Commit 57c91aa

Browse files
authored
[private-classnames] Remove package and move everything to utils (mui#32758)
1 parent 6972036 commit 57c91aa

File tree

40 files changed

+28
-124
lines changed

40 files changed

+28
-124
lines changed

.codesandbox/ci.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
"@mui/styled-engine-sc": "packages/mui-styled-engine-sc/build",
2929
"@mui/system": "packages/mui-system/build",
3030
"@mui/private-theming": "packages/mui-private-theming/build",
31-
"@mui/private-classnames": "packages/mui-private-classnames/build",
3231
"@mui/types": "packages/mui-types/build",
3332
"@mui/utils": "packages/mui-utils/build",
3433
"@mui/base": "packages/mui-base/build",

babel.config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ const defaultAlias = {
1818
'@mui/styles': resolveAliasPath('./packages/mui-styles/src'),
1919
'@mui/system': resolveAliasPath('./packages/mui-system/src'),
2020
'@mui/private-theming': resolveAliasPath('./packages/mui-private-theming/src'),
21-
'@mui/private-classnames': resolveAliasPath('./packages/mui-private-classnames/src'),
2221
'@mui/base': resolveAliasPath('./packages/mui-base/src'),
2322
'@mui/utils': resolveAliasPath('./packages/mui-utils/src'),
2423
'@mui/material-next': resolveAliasPath('./packages/mui-material-next/src'),

docs/babel.config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ const alias = {
2525
// '@mui/styled-engine': '../packages/mui-styled-engine-sc/src',
2626
'@mui/system': '../packages/mui-system/src',
2727
'@mui/private-theming': '../packages/mui-private-theming/src',
28-
'@mui/private-classnames': '../packages/mui-private-classnames/src',
2928
'@mui/utils': '../packages/mui-utils/src',
3029
'@mui/base': '../packages/mui-base/src',
3130
'@mui/material-next': '../packages/mui-material-next/src',

docs/next.config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,6 @@ module.exports = {
137137
'@mui/styles': '../packages/mui-styles/src',
138138
'@mui/system': '../packages/mui-system/src',
139139
'@mui/private-theming': '../packages/mui-private-theming/src',
140-
'@mui/private-classnames': '../packages/mui-private-classnames/src',
141140
'@mui/utils': '../packages/mui-utils/src',
142141
'@mui/base': '../packages/mui-base/src',
143142
'@mui/material-next': '../packages/mui-material-next/src',

docs/src/modules/utils/helpers.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,6 @@ export function getDependencies(
169169
'@mui/styles': getMuiPackageVersion('styles', muiCommitRef),
170170
'@mui/system': getMuiPackageVersion('system', muiCommitRef),
171171
'@mui/private-theming': getMuiPackageVersion('theming', muiCommitRef),
172-
'@mui/private-classnames': getMuiPackageVersion('classnames', muiCommitRef),
173172
'@mui/base': getMuiPackageVersion('base', muiCommitRef),
174173
'@mui/utils': getMuiPackageVersion('utils', muiCommitRef),
175174
'@mui/material-next': getMuiPackageVersion('material-next', muiCommitRef),

packages/mui-base/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@
5353
"dependencies": {
5454
"@babel/runtime": "^7.17.2",
5555
"@emotion/is-prop-valid": "^1.1.2",
56-
"@mui/private-classnames": "^5.7.0",
5756
"@mui/types": "^7.1.3",
5857
"@mui/utils": "^5.7.0",
5958
"@popperjs/core": "^2.11.5",
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
// eslint-disable-next-line import/prefer-default-export
2-
export { unstable_ClassNameGenerator } from '@mui/private-classnames';
2+
export { unstable_ClassNameGenerator } from '@mui/utils';
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
export { unstable_composeClasses as default } from '@mui/private-classnames';
1+
export { unstable_composeClasses as default } from '@mui/utils';
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
export { generateUtilityClass as default } from '@mui/private-classnames';
2-
export type { GlobalStateSlot } from '@mui/private-classnames';
1+
export { unstable_generateUtilityClass as default } from '@mui/utils';
2+
export type { GlobalStateSlot } from '@mui/utils';
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
export { generateUtilityClasses as default } from '@mui/private-classnames';
1+
export { unstable_generateUtilityClasses as default } from '@mui/utils';

packages/mui-base/tsconfig.build.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,5 @@
1111
"rootDir": "./src"
1212
},
1313
"include": ["src/**/*.ts*"],
14-
"exclude": ["src/**/*.spec.ts*", "src/**/*.test.ts*"],
15-
"references": [{ "path": "../mui-private-classnames/tsconfig.build.json" }]
14+
"exclude": ["src/**/*.spec.ts*", "src/**/*.test.ts*"]
1615
}

packages/mui-material/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@
6262
"dependencies": {
6363
"@babel/runtime": "^7.17.2",
6464
"@mui/base": "5.0.0-alpha.80",
65-
"@mui/private-classnames": "^5.7.0",
6665
"@mui/system": "^5.7.0",
6766
"@mui/types": "^7.1.3",
6867
"@mui/utils": "^5.7.0",

packages/mui-material/scripts/rollup.config.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,10 +102,6 @@ const nestedFolder = {
102102
return resolveNestedImport('mui-private-theming', importee);
103103
}
104104

105-
if (importee.indexOf('@mui/private-classnames/') === 0) {
106-
return resolveNestedImport('mui-private-classnames', importee);
107-
}
108-
109105
if (importee.indexOf('@mui/styled-engine/') === 0) {
110106
return resolveNestedImport('mui-styled-engine', importee);
111107
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
// eslint-disable-next-line import/prefer-default-export
2-
export { unstable_ClassNameGenerator } from '@mui/private-classnames';
2+
export { unstable_ClassNameGenerator } from '@mui/utils';

packages/mui-private-classnames/README.md

Lines changed: 0 additions & 3 deletions
This file was deleted.

packages/mui-private-classnames/package.json

Lines changed: 0 additions & 46 deletions
This file was deleted.

packages/mui-private-classnames/src/index.d.ts

Lines changed: 0 additions & 11 deletions
This file was deleted.

packages/mui-private-classnames/src/index.js

Lines changed: 0 additions & 4 deletions
This file was deleted.

packages/mui-private-classnames/tsconfig.build.json

Lines changed: 0 additions & 15 deletions
This file was deleted.

packages/mui-private-classnames/tsconfig.json

Lines changed: 0 additions & 4 deletions
This file was deleted.

packages/mui-system/src/Container/containerClasses.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
import { generateUtilityClass, generateUtilityClasses } from '@mui/private-classnames';
1+
import {
2+
unstable_generateUtilityClass as generateUtilityClass,
3+
unstable_generateUtilityClasses as generateUtilityClasses,
4+
} from '@mui/utils';
25

36
export interface ContainerClasses {
47
/** Styles applied to the root element. */

packages/mui-system/src/Container/createContainer.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@ import * as React from 'react';
22
import PropTypes from 'prop-types';
33
import clsx from 'clsx';
44
import { Interpolation, StyledComponent } from '@mui/styled-engine';
5-
import { unstable_capitalize as capitalize } from '@mui/utils';
65
import { OverridableComponent } from '@mui/types';
76
import {
7+
unstable_capitalize as capitalize,
88
unstable_composeClasses as composeClasses,
9-
generateUtilityClass,
10-
} from '@mui/private-classnames';
9+
unstable_generateUtilityClass as generateUtilityClass,
10+
} from '@mui/utils';
1111
import { ContainerProps, ContainerTypeMap } from './ContainerProps';
1212
import useThemePropsSystem from '../useThemeProps';
1313
import systemStyled from '../styled';

packages/mui-system/tsconfig.build.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,5 @@
1111
"rootDir": "./src"
1212
},
1313
"include": ["src/**/*.ts*"],
14-
"exclude": ["src/**/*.spec.ts", "src/**/*.test.ts"],
15-
"references": [{ "path": "../mui-private-classnames/tsconfig.build.json" }]
14+
"exclude": ["src/**/*.spec.ts", "src/**/*.test.ts"]
1615
}

packages/mui-utils/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,14 @@
2626
"url": "https://opencollective.com/mui"
2727
},
2828
"scripts": {
29-
"build": "yarn build:legacy && yarn build:modern && yarn build:node && yarn build:stable && yarn build:copy-files && yarn build:types",
29+
"build": "yarn build:legacy && yarn build:modern && yarn build:node && yarn build:stable && yarn build:types && yarn build:copy-files",
3030
"build:legacy": "node ../../scripts/build legacy",
3131
"build:modern": "node ../../scripts/build modern",
3232
"build:node": "node ../../scripts/build node",
3333
"build:stable": "node ../../scripts/build stable",
3434
"build:copy-files": "node ../../scripts/copy-files.js",
3535
"build:types": "node ../../scripts/buildTypes",
36-
"prebuild": "rimraf build",
36+
"prebuild": "rimraf build tsconfig.build.tsbuildinfo",
3737
"release": "yarn build && npm publish build",
3838
"test": "cd ../../ && cross-env NODE_ENV=test mocha 'packages/mui-utils/**/*.test.{js,ts,tsx}'",
3939
"typescript": "tslint -p tsconfig.json \"{src,test}/**/*.{spec,d}.{ts,tsx}\" && tsc -p tsconfig.json"

packages/mui-private-classnames/src/composeClasses/composeClasses.test.js renamed to packages/mui-utils/src/composeClasses/composeClasses.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { expect } from 'chai';
2-
import { unstable_composeClasses as composeClasses } from '@mui/private-classnames';
2+
import { unstable_composeClasses as composeClasses } from '@mui/utils';
33

44
describe('composeClasses', () => {
55
it('should generate the classes based on the slots', () => {

packages/mui-private-classnames/src/generateUtilityClass/generateUtilityClass.test.js renamed to packages/mui-utils/src/generateUtilityClass/generateUtilityClass.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import { expect } from 'chai';
22
import {
3-
generateUtilityClass,
3+
unstable_generateUtilityClass as generateUtilityClass,
44
unstable_ClassNameGenerator as ClassNameGenerator,
5-
} from '@mui/private-classnames';
5+
} from '@mui/utils';
66

77
describe('generateUtilityClass', () => {
88
it('should generate the class correctly', () => {
@@ -27,14 +27,14 @@ describe('generateUtilityClass', () => {
2727
});
2828

2929
it('able to set custom generator', () => {
30-
const generator = (name) => `foo-bar-${name}`;
30+
const generator = (name: string) => `foo-bar-${name}`;
3131
ClassNameGenerator.configure(generator);
3232

3333
expect(generateUtilityClass('MuiTest', 'slot')).to.equal('foo-bar-MuiTest-slot');
3434
});
3535

3636
it('does not affect state class', () => {
37-
const generator = (name) => `foo-bar-${name}`;
37+
const generator = (name: string) => `foo-bar-${name}`;
3838
ClassNameGenerator.configure(generator);
3939

4040
expect(generateUtilityClass('MuiTest', 'active')).to.equal('Mui-active');
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { expect } from 'chai';
2-
import { generateUtilityClasses } from '@mui/private-classnames';
2+
import { unstable_generateUtilityClasses as generateUtilityClasses } from '@mui/utils';
33

44
describe('generateUtilityClasses', () => {
55
it('should generate the classes correctly', () => {

packages/mui-utils/src/index.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,3 +34,8 @@ export { default as usePreviousProps } from './usePreviousProps';
3434
export { default as visuallyHidden } from './visuallyHidden';
3535
export { default as integerPropType } from './integerPropType';
3636
export { default as internal_resolveProps } from './resolveProps';
37+
export { default as unstable_composeClasses } from './composeClasses';
38+
export { default as unstable_generateUtilityClass } from './generateUtilityClass';
39+
export * from './generateUtilityClass';
40+
export { default as unstable_generateUtilityClasses } from './generateUtilityClasses';
41+
export { default as unstable_ClassNameGenerator } from './ClassNameGenerator';

scripts/sizeSnapshot/webpack.config.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -216,10 +216,6 @@ function createWebpackConfig(entry, environment) {
216216
'@mui/styles': path.join(workspaceRoot, 'packages/mui-styles/build'),
217217
'@mui/system': path.join(workspaceRoot, 'packages/mui-system/build'),
218218
'@mui/private-theming': path.join(workspaceRoot, 'packages/mui-private-theming/build'),
219-
'@mui/private-classnames': path.join(
220-
workspaceRoot,
221-
'packages/mui-private-classnames/build',
222-
),
223219
'@mui/utils': path.join(workspaceRoot, 'packages/mui-utils/build'),
224220
'@mui/base': path.join(workspaceRoot, 'packages/mui-base/build'),
225221
'@mui/material-next': path.join(workspaceRoot, 'packages/mui-material-next/build'),

test/karma.conf.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,6 @@ module.exports = function setKarmaConfig(config) {
156156
'@mui/styles': './packages/mui-styles/src',
157157
'@mui/system': './packages/mui-system/src',
158158
'@mui/private-theming': './packages/mui-private-theming/src',
159-
'@mui/private-classnames': './packages/mui-private-classnames/src',
160159
'@mui/utils': './packages/mui-utils/src',
161160
'@mui/base': './packages/mui-base/src',
162161
'@mui/material-next': './packages/mui-material-next/src',

tsconfig.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@
2828
"@mui/system": ["./packages/mui-system/src"],
2929
"@mui/private-theming": ["./packages/mui-private-theming/src"],
3030
"@mui/private-theming/*": ["./packages/mui-private-theming/src/*"],
31-
"@mui/private-classnames": ["./packages/mui-private-classnames/src"],
32-
"@mui/private-classnames/*": ["./packages/mui-private-classnames/src/*"],
3331
"@mui/types": ["./packages/mui-types"],
3432
"@mui/base": ["./packages/mui-base/src"],
3533
"@mui/base/*": ["./packages/mui-base/src/*"],

webpackBaseConfig.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ module.exports = {
1818
'@mui/styles': path.resolve(__dirname, './packages/mui-styles/src'),
1919
'@mui/system': path.resolve(__dirname, './packages/mui-system/src'),
2020
'@mui/private-theming': path.resolve(__dirname, './packages/mui-private-theming/src'),
21-
'@mui/private-classnames': path.resolve(__dirname, './packages/mui-private-classnames/src'),
2221
'@mui/base': path.resolve(__dirname, './packages/mui-base/src'),
2322
'@mui/utils': path.resolve(__dirname, './packages/mui-utils/src'),
2423
'@mui/material-next': path.resolve(__dirname, './packages/mui-material-next/src'),

0 commit comments

Comments
 (0)