Mock ChatHistoryManager (in a friendly banter sort of way)

Author: mliu-cloudera

llm-service/app/tests/provider_mocks/__init__.py renamed to llm-service/app/tests/model_provider_mocks/__init__.py

@@ -48,6 +48,10 @@
 from app.config import settings
 from app.services.caii.types import ModelResponse
 from app.services.models.providers import BedrockModelProvider
+from .testing_chat_history_manager import (
+    patch_get_chat_history_manager,
+    TestingChatHistoryManager,
+)
 from .utils import patch_env_vars
 
 TEXT_MODELS = [
@@ -149,7 +153,7 @@ def mock_make_api_call(self, operation_name: str, api_params: dict[str, str]):
     return patch("botocore.client.BaseClient._make_api_call", new=mock_make_api_call)
 
 
-@pytest.fixture
+@pytest.fixture(autouse=True)
 def mock_bedrock(monkeypatch) -> Iterator[None]:
     with patch_env_vars(BedrockModelProvider):
         with (
@@ -170,8 +174,8 @@ def mock_bedrock(monkeypatch) -> Iterator[None]:
             yield
 
 
-# TODO: move this test function to a discoverable place
-def test_bedrock(mock_bedrock, client) -> None:
+# TODO: move test functions to a discoverable place
+def test_bedrock_models(client) -> None:
     response = client.get("/llm-service/models/model_source")
     assert response.status_code == 200
     assert response.json() == "Bedrock"
@@ -199,3 +203,38 @@ def test_bedrock(mock_bedrock, client) -> None:
         for model_id, availability in RERANKING_MODELS
         if availability == "AVAILABLE"
     ]
+
+    # response = client.get("/llm-service/models/embedding/cohere.embed-english-v3/test")
+
+
+def test_bedrock_sessions(client) -> None:
+    session_id = 1
+    with patch_get_chat_history_manager() as get_testing_chat_history_manager:
+        chat_history = get_testing_chat_history_manager().retrieve_chat_history(
+            session_id=session_id
+        )
+
+        response = client.get(f"/llm-service/sessions/{session_id}/chat-history")
+        assert response.status_code == 200
+        assert response.json()["data"] == [msg.model_dump() for msg in chat_history]
+
+        msg = chat_history[0]  # TODO: randomize?
+        response = client.get(
+            f"/llm-service/sessions/{msg.session_id}/chat-history/{msg.id}",
+        )
+        assert response.status_code == 200
+        assert response.json() == msg.model_dump()
+
+        # TODO: maybe call the chat endpoint and see if history changes
+
+    # response = client.post("/llm-service/sessions/1/rename-session")
+    # assert response.status_code == 200
+
+
+# def test_bedrock_chat(client) -> None:
+#     response = client.post("/llm-service/sessions/suggest-questions")
+#     print(f"{response.json()=}")
+#     assert response.status_code == 200
+#
+#     response = client.post("/llm-service/sessions/1/stream-completion")
+#     assert response.status_code == 200

llm-service/app/tests/provider_mocks/bedrock.py renamed to llm-service/app/tests/model_provider_mocks/bedrock.py

@@ -0,0 +1,99 @@
+#
+#  CLOUDERA APPLIED MACHINE LEARNING PROTOTYPE (AMP)
+#  (C) Cloudera, Inc. 2025
+#  All rights reserved.
+#
+#  Applicable Open Source License: Apache 2.0
+#
+#  NOTE: Cloudera open source products are modular software products
+#  made up of hundreds of individual components, each of which was
+#  individually copyrighted.  Each Cloudera open source product is a
+#  collective work under U.S. Copyright Law. Your license to use the
+#  collective work is as provided in your written agreement with
+#  Cloudera.  Used apart from the collective work, this file is
+#  licensed for your use pursuant to the open source license
+#  identified above.
+#
+#  This code is provided to you pursuant a written agreement with
+#  (i) Cloudera, Inc. or (ii) a third-party authorized to distribute
+#  this code. If you do not have a written agreement with Cloudera nor
+#  with an authorized and properly licensed third party, you do not
+#  have any rights to access nor to use this code.
+#
+#  Absent a written agreement with Cloudera, Inc. ("Cloudera") to the
+#  contrary, A) CLOUDERA PROVIDES THIS CODE TO YOU WITHOUT WARRANTIES OF ANY
+#  KIND; (B) CLOUDERA DISCLAIMS ANY AND ALL EXPRESS AND IMPLIED
+#  WARRANTIES WITH RESPECT TO THIS CODE, INCLUDING BUT NOT LIMITED TO
+#  IMPLIED WARRANTIES OF TITLE, NON-INFRINGEMENT, MERCHANTABILITY AND
+#  FITNESS FOR A PARTICULAR PURPOSE; (C) CLOUDERA IS NOT LIABLE TO YOU,
+#  AND WILL NOT DEFEND, INDEMNIFY, NOR HOLD YOU HARMLESS FOR ANY CLAIMS
+#  ARISING FROM OR RELATED TO THE CODE; AND (D)WITH RESPECT TO YOUR EXERCISE
+#  OF ANY RIGHTS GRANTED TO YOU FOR THE CODE, CLOUDERA IS NOT LIABLE FOR ANY
+#  DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, PUNITIVE OR
+#  CONSEQUENTIAL DAMAGES INCLUDING, BUT NOT LIMITED TO, DAMAGES
+#  RELATED TO LOST REVENUE, LOST PROFITS, LOSS OF INCOME, LOSS OF
+#  BUSINESS ADVANTAGE OR UNAVAILABILITY, OR LOSS OR CORRUPTION OF
+#  DATA.
+#
+import time
+import uuid
+from contextlib import AbstractContextManager
+from typing import Callable
+from unittest.mock import patch
+
+from alembic.testing.fixtures import testing_config
+
+from app.services.chat_history.chat_history_manager import (
+    ChatHistoryManager,
+    RagStudioChatMessage,
+    RagMessage,
+)
+from app.services.models import get_provider_class
+
+
+class TestingChatHistoryManager(ChatHistoryManager):
+    def __init__(self):
+        self._chat_history: dict[int, list[RagStudioChatMessage]] = dict()
+
+    def retrieve_chat_history(self, session_id: int) -> list[RagStudioChatMessage]:
+        return self._chat_history.get(session_id, [])
+
+    def clear_chat_history(self, session_id: int) -> None:
+        self._chat_history[session_id] = []
+
+    def delete_chat_history(self, session_id: int) -> None:
+        del self._chat_history[session_id]
+
+    def append_to_history(
+        self, session_id: int, messages: list[RagStudioChatMessage]
+    ) -> None:
+        self._chat_history.setdefault(session_id, []).extend(messages)
+
+
+def patch_get_chat_history_manager() -> (
+    AbstractContextManager[Callable[[], TestingChatHistoryManager]]
+):
+    session_id = 1
+    testing_chat_history_manager = TestingChatHistoryManager()
+    testing_chat_history_manager.append_to_history(
+        session_id,
+        [
+            RagStudioChatMessage(
+                id=str(uuid.uuid4()),
+                session_id=session_id,
+                source_nodes=[],
+                inference_model=get_provider_class()
+                .list_llm_models()[0]  # TODO: randomize?
+                .model_id,
+                rag_message=RagMessage(user="test question", assistant="test answer"),
+                evaluations=[],
+                timestamp=time.time(),
+                condensed_question=None,
+            )
+        ],
+    )
+
+    return patch(
+        "app.services.chat_history.chat_history_manager._get_chat_history_manager",
+        new=lambda: testing_chat_history_manager,
+    )

llm-service/app/tests/model_provider_mocks/testing_chat_history_manager.py

@@ -44,7 +44,7 @@
 from app.services.caii.types import ListEndpointEntry
 from app.services.models.providers import BedrockModelProvider
 from app.services.models.providers._model_provider import _ModelProvider
-from app.tests.provider_mocks.utils import patch_env_vars
+from app.tests.model_provider_mocks.utils import patch_env_vars
 
 
 @pytest.fixture(params=_ModelProvider.__subclasses__())