Spring integration

[slinkydeveloper]

Given the ongoing work on jaxrs implementation, what it takes to integrate with spring?

[slinkydeveloper]

Ping @bsideup

[bsideup]

cc @olegz (Spring Cloud)

[olegz]

I guess there should be clarification on what type of integration you are looking for. Spring provides variety of ways to expose user functionality as REST endpoints. Some of them require user to no configuration at all. I can certainly elaborate further but it would help if more specifics are shared

[slinkydeveloper]

The Jax-Rs integration will consists of a @Provider implementing MessageBodyReader and MessageBodyWriter.

[dsyer]

There are many equivalents to MessageBodyReader and MessageBodyWriter in Spring (depending on blocking or non-blocking, HTTP, AMQP, Kafka, JMS, etc.). I think rather than try and implement them all here it would be better just to present a clean, stable API.

[slinkydeveloper]

@olegz @dsyer draft of the jaxrs implementation is here: #145

Can it work OOTB with Spring?

[dsyer]

Anyone who used JAX-RS with Spring I imagine could register the @Provider - I think that's the way it works with Spring Boot. The MessageUtils looks useful as well for internal use in Spring maybe (I see you used it in the Kafka binding already).

[slinkydeveloper]

I've merged the jax-rs integration https://github.com/cloudevents/sdk-java/tree/master/http/restful-ws

Let me know if this is enough to work OOTB with Spring or if we need something else 😄 . If we want to leverage some features specific to Spring, we can definitely have a module like http/spring

[bsideup]

@slinkydeveloper when you're saying "work OOTB with Spring" - do you mean that this is enough to call it "Spring support", or that, when Spring's JAX-RS integration is used, the module works?
Because Spring is not based on JAX-RS (but there are options to use JAX-RS with Spring)

edit: @slinkydeveloper's comment was edited and mine makes little sense now, but I will keep it here for clarity, because there seem to be some misconception

[slinkydeveloper]

Because Spring is not based on JAX-RS (but there are options to use JAX-RS with Spring)

Ah ok, please forget my ignorance about that 😄

[cmoulliard]

For Spring, then we should add a new module within this SDK implementing Spring Web- https://github.com/spring-projects/spring-framework/tree/master/spring-web

[slinkydeveloper]

@cmoulliard are you willing to give a try to it? 😄

[bsideup]

@slinkydeveloper I would highly recommend to contact the Spring team before proceeding, to ensure that what you're doing here is aligned with what will be the official CloudEvents support in Spring.

[cmoulliard]

what will be the official CloudEvents support in Spring.

Where such official CloudEvents vision is defined and communicated for the spring users/developers ? @bsideup

[olegz]

@cmoulliard at the moment it is not very clear as to what does Spring support even mean, since Spring portfolio consists of many projects. As for communication . . as an example, we have request in spring-cloud-function to add Cloud Events support which most likely be a simply translation layer between Spring Message and CloudEvent, since their structures are pretty much identical.

Basically IMHO I don't think the terminology such as "CloudEvents support in Spring" or "Spring Integration" - (which is also the name of one of Spring's frameworks) is appropriate or meaningful without further clarifying which specific part of Spring one is referring to.