[Docs Site] Remove unnecessary ts-expect-error directives (#19680)

Author: KianNH

eslint.config.js

@@ -32,7 +32,6 @@ export default [
 		rules: {
 			"no-var": "error",
 			"@typescript-eslint/no-explicit-any": "off",
-			"@typescript-eslint/triple-slash-reference": "off",
 			"@typescript-eslint/no-unused-vars": [
 				"error",
 				{ ignoreRestSiblings: true },

src/components/ListExamples.astro

@@ -1,16 +1,17 @@
 ---
 import { z } from "astro:schema";
-import { getCollection } from "astro:content";
+import { getCollection, type CollectionEntry } from "astro:content";
 import { marked } from "marked";
 
 import { CardGrid } from "@astrojs/starlight/components";
 import LinkTitleCard from "~/components/LinkTitleCard.astro";
 
 type Props = z.infer<typeof props>;
+type Data = keyof CollectionEntry<"docs">["data"];
 
 const props = z.object({
 	directory: z.string().optional(),
-	filters: z.string().array().optional(),
+	filters: z.custom<Data>().array().optional(),
 	additionalProducts: z.string().array().optional(),
 });
 
@@ -36,13 +37,15 @@ const examples = await getCollection("docs", (entry) => {
 });
 
 const filterValues: Record<string, string[]> = {};
+
 if (filters) {
 	for (const filter of filters) {
 		const values = examples.flatMap((x) =>
-			// @ts-expect-error indexing frontmatter with string
 			filter in x.data ? x.data[filter] : [],
 		);
-		const unique = [...new Set(values)];
+
+		const unique = [...new Set(values.flatMap((v) => v?.toString() ?? []))];
+
 		filterValues[filter] = unique;
 	}
 }
@@ -79,16 +82,14 @@ if (filters) {
 			examples
 				.sort((a, b) => a.data.title.localeCompare(b.data.title))
 				.map((example) => {
-					const filterAttributes = {};
+					const filterAttributes: { [index: string]: any } = {};
+
 					if (filters) {
 						for (const filter of filters) {
 							const hasFilterableProperty = filter in example.data;
 
 							if (hasFilterableProperty) {
-								// @ts-expect-error can't use TS generics inside JSX
-								filterAttributes[`data-${filter}`] =
-									// @ts-expect-error indexing frontmatter with string
-									example.data[filter];
+								filterAttributes[`data-${filter}`] = example.data[filter];
 							}
 						}
 					}

src/components/ListTutorials.astro

@@ -27,13 +27,20 @@ const tutorials = await getCollection("docs", (entry) => {
 });
 
 type VideoEntry = InferEntrySchema<"videos">["entries"][number];
+
 type FinalTutorials = {
 	slug?: string;
-	data: InferEntrySchema<"docs"> | VideoEntry;
+	data:
+		| ({ type: "docs" } & InferEntrySchema<"docs">)
+		| ({ type: "videos" } & VideoEntry);
 }[];
+
 const finalTutorials: FinalTutorials = tutorials.map((x) => ({
 	slug: x.id,
-	data: x.data,
+	data: {
+		type: "docs",
+		...x.data,
+	},
 }));
 
 const videos = await getEntry("videos", "index");
@@ -49,7 +56,14 @@ const filteredVideos = videos.data.entries.filter((x) =>
 );
 
 if (filteredVideos) {
-	filteredVideos.forEach((x) => finalTutorials.push({ data: x }));
+	filteredVideos.forEach((x) =>
+		finalTutorials.push({
+			data: {
+				type: "videos",
+				...x,
+			},
+		}),
+	);
 }
 
 finalTutorials.sort((a, b) => Number(b.data.updated) - Number(a.data.updated));
@@ -72,8 +86,10 @@ const timeAgo = (date?: Date) => {
 	<tbody>
 		{
 			finalTutorials.map((tutorial) => {
-				// @ts-expect-error TODO: improve types
-				const href = tutorial.slug ? `/${tutorial.slug}` : tutorial.data.link;
+				const href =
+					tutorial.data.type === "docs"
+						? `/${tutorial.slug}/`
+						: tutorial.data.link;
 				return (
 					<tr>
 						<td>

src/components/Plan.astro

@@ -27,15 +27,13 @@ const props = z
 		}),
 	);
 
-// @ts-expect-error plans are not typed
-const { id, type } = props.parse(Astro.props);
+const input = props.parse(Astro.props);
 
 let availability;
-if (type) {
-	// @ts-expect-error plans are not typed
-	availability = mappings[type];
+if ("type" in input) {
+	availability = mappings[input.type];
 } else {
-	availability = await indexPlans(id);
+	availability = await indexPlans(input.id);
 }
 ---