Skip to content

Commit ed1720e

Browse files
committed
CI: increase unit test timeout in cf-d pipeline
It appears that switching to the new ARD concourse has slowed down runs of these unit tests significantly. Previously taking ~10 mins, they are now requiring more than 20 mins. For now, I'm just going to increase the timeout. We should try and speed this up though. Either by powering up the containers that tasks run in, or by making these unit tests parallelizable. Since we already had a 20 min timeout in the test script, I was unable to plugin a timeout using concourse config args. Therefore, I stripped the hard coded timeout from the test script, thinking that we can just hardcode the timeout into CI wherever we need. The two timeouts I've set so far are: * cf-deployment/unit-test-golang-tests: 1h * pull-requests/run-unit-tests-on-all-cf-deployment-prs: 20 mins
1 parent 2add760 commit ed1720e

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

ci/pipelines/cf-deployment.yml

+3
Original file line numberDiff line numberDiff line change
@@ -403,6 +403,9 @@ jobs:
403403
run:
404404
dir: cf-deployment-develop/units
405405
path: ./test
406+
args:
407+
- -timeout
408+
- 1h
406409

407410
- name: unit-test-update-releases-coverage
408411
serial: true

ci/pipelines/pull-requests.yml

+3-1
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,6 @@ jobs:
184184
path: scripts/test
185185
- task: unit-test-golang-ops-files
186186
config:
187-
188187
platform: linux
189188
image_resource:
190189
type: docker-image
@@ -195,6 +194,9 @@ jobs:
195194
run:
196195
dir: cf-deployment-all-branches/units
197196
path: ./test
197+
args:
198+
- -timeout
199+
- 20m
198200
on_failure:
199201
do:
200202
- task: write-pr-check-failure-comment

units/test

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,5 @@ pushd "$(dirname "$0")" > /dev/null
2323
fi
2424

2525
echo "Starting unit tests..."
26-
go test "$@" $(suites) -timeout=20m
26+
go test "$@" $(suites)
2727
popd > /dev/null

0 commit comments

Comments
 (0)