Skip to content

Commit 315ab98

Browse files
Gergrobdimsdale
authored andcommitted
Move node-semver to submodule and upgrade
- Despite the name, this is a python package - The whole git module was vendored, so making it a submodule will make it easier to upgrade in the future - Upgrade to the latest version to remove python3 syntax warnings from app staging logs
1 parent acbfbbe commit 315ab98

25 files changed

+5
-1995
lines changed

.gitmodules

+3
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,6 @@
77
[submodule "fixtures/composer_no_index_dot_php/vendor/psr/log"]
88
path = fixtures/composer_no_index_dot_php/vendor/psr/log
99
url = https://github.com/php-fig/log
10+
[submodule "python-vendor/node-semver"]
11+
path = python-vendor/node-semver
12+
url = [email protected]:podhmo/python-node-semver.git

extensions/composer/extension.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
from extension_helpers import ExtensionHelper
3232

3333
sys.path.append(os.path.join(os.path.dirname(os.path.abspath(__file__)), '..', '..', 'python-vendor', 'node-semver'))
34-
from semver import max_satisfying
34+
from nodesemver import max_satisfying
3535

3636
from build_pack_utils.compile_extensions import CompileExtensions
3737

python-vendor/node-semver

Submodule node-semver added at 759097c

python-vendor/node-semver/.gitignore

-54
This file was deleted.

python-vendor/node-semver/CHANGES.txt

-1
This file was deleted.

python-vendor/node-semver/LICENSE

-21
This file was deleted.

python-vendor/node-semver/Makefile

-9
This file was deleted.

python-vendor/node-semver/README.rst

-23
This file was deleted.

python-vendor/node-semver/demo.py

-16
This file was deleted.

0 commit comments

Comments
 (0)