Fix line ending bug (#49)

Author: calebeby

.changeset/gold-onions-behave.md

@@ -0,0 +1,5 @@
+---
+'lighthouse-parade': minor
+---
+
+Fix line ending bug

examples/exampleAggregatedMobileReport.csv

@@ -21,5 +21,5 @@ export const runLighthouseReport = async (url: string) => {
     throw new Error(`Lighthouse report failed for: ${url}`);
   }
 
-  return stdout;
+  return String(stdout).replace(/\r\n/g, '\n');
 };

lighthouse.ts

@@ -25,10 +25,10 @@ export const reportToRow = (csvFileContents: string) => {
   const reportRows: LighthouseCSVReportRow[] | undefined = csvParse(
     csvFileContents,
     {
+      // https://csv.js.org/parse/options/
       columns: true,
       skip_empty_lines: true,
       ltrim: true,
-      relax: true, // https://csv.js.org/parse/options/
     }
   );
   // Sometimes reports come out half-baked...

report-to-row.ts

@@ -77,6 +77,7 @@ export const scan = (
     }
 
     emit('info', 'Aggregating reports...');
+    // TODO: Make aggregateCSVReports work without filesystem, for testing
     const aggregatedReportData = aggregateCSVReports(reportsDirPath);
     if (!aggregatedReportData) return;
 

scan-task.ts

@@ -1,5 +1,3 @@
 Requested URL,Final URL,Performance: Overall Performance Category Score (numeric),Performance: First Contentful Paint (numeric),Performance: Speed Index (numeric),Performance: Largest Contentful Paint (numeric),Performance: Time to Interactive (numeric),Performance: Total Blocking Time (numeric),Performance: Cumulative Layout Shift (numeric),Performance: First CPU Idle (numeric),Performance: Max Potential First Input Delay (numeric),Performance: First Meaningful Paint (numeric),Performance: Estimated Input Latency (numeric),Performance: Eliminate render-blocking resources (numeric),Performance: Properly size images (numeric),Performance: Defer offscreen images (numeric),Performance: Minify CSS (numeric),Performance: Minify JavaScript (numeric),Performance: Remove unused CSS (numeric),Performance: Remove unused JavaScript (numeric),Performance: Efficiently encode images (numeric),Performance: Serve images in next-gen formats (numeric),Performance: Enable text compression (numeric),Performance: Preconnect to required origins (numeric),Performance: Initial server response time was short (binary),Performance: Avoid multiple page redirects (numeric),Performance: Preload key requests (numeric),Performance: Use HTTP/2 (binary),Performance: Use video formats for animated content (numeric),Performance: Remove duplicate modules in JavaScript bundles (numeric),Performance: Avoid serving legacy JavaScript to modern browsers (numeric),Performance: Avoid enormous network payloads (numeric),Performance: Serve static assets with an efficient cache policy (numeric),Performance: Avoids an excessive DOM size (numeric),Performance: Avoid chaining critical requests (informative),Performance: User Timing marks and measures (notApplicable),Performance: JavaScript execution time (numeric),Performance: Minimizes main-thread work (numeric),Performance: Ensure text remains visible during webfont load (binary),Performance: Performance budget (notApplicable),Performance: Timing budget (notApplicable),Performance: Keep request counts low and transfer sizes small (informative),Performance: Minimize third-party usage (binary),Performance: Largest Contentful Paint element (informative),Performance: Avoid large layout shifts (informative),Performance: Uses passive listeners to improve scrolling performance (binary),Performance: Avoids `document.write()` (binary),Performance: Avoid long main-thread tasks (informative),Performance: Avoid non-composited animations (notApplicable),Performance: Image elements do not have explicit `width` and `height` (binary),Performance: Avoids large JavaScript libraries with smaller alternatives (binary),Performance: Network Requests (informative),Performance: Network Round Trip Times (informative),Performance: Server Backend Latencies (informative),Performance: Tasks (informative),Performance: Diagnostics (informative),Performance: Metrics (informative),Performance: Screenshot Thumbnails (informative),Performance: Final Screenshot (informative)
-https://lombardstreettattoo.com/,https://lombardstreettattoo.com/,1,1,1,0.98,1,1,1,1,0.27,1,1,0.78,0,1,0.87,1,0.87,1,1,0,1,1,1,1,0.66,1,1,1,1,0.28,0.14,1,-1,-1,1,1,0,-1,-1,-1,1,-1,-1,1,1,-1,-1,0,1,-1,-1,-1,-1,-1,-1,-1,"""-1""
-"
-https://lombardstreettattoo.com/cdn-cgi/l/email-protection,https://lombardstreettattoo.com/cdn-cgi/l/email-protection,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,-1,-1,1,1,1,-1,-1,-1,-1,-1,-1,1,1,-1,-1,-1,1,-1,-1,-1,-1,-1,-1,-1,"""-1""
-"
+https://lombardstreettattoo.com/,https://lombardstreettattoo.com/,1,1,1,0.98,1,1,1,1,0.27,1,1,0.78,0,1,0.87,1,0.87,1,1,0,1,1,1,1,0.66,1,1,1,1,0.28,0.14,1,-1,-1,1,1,0,-1,-1,-1,1,-1,-1,1,1,-1,-1,0,1,-1,-1,-1,-1,-1,-1,-1,-1
+https://lombardstreettattoo.com/cdn-cgi/l/email-protection,https://lombardstreettattoo.com/cdn-cgi/l/email-protection,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,-1,-1,1,1,1,-1,-1,-1,-1,-1,-1,1,1,-1,-1,-1,1,-1,-1,-1,-1,-1,-1,-1,-1