clean up clippy warnings

Author: cloudsftp

README.org

@@ -96,7 +96,6 @@ Options:
       --tcp-port <tcp-port>            TCP port for video stream (default: 6680)
       --ssh-key <ssh-key>              Private SSH key file path. If not specified, attempting all keys in the SSH directory
       --framerate <framerate>          Framerate (default: 50)
-      --dark-mode                      Dark mode - invert colors (default: false)
       --show-cursor                    Show cursor (default: false)
   -h, --help                           Print help
   -V, --version                        Print version
@@ -109,7 +108,6 @@ Corresponding keys:
 - =REMARKABLE_TCP_PORT=
 - =REMARKABLE_SSH_KEY_PATH=
 - =REMARKABLE_FRAMERATE=
-- =REMARKABLE_DARK_MODE=
 - =REMARKABLE_SHOW_CURSOR=
 
 * Building

client/src/config.rs

@@ -33,8 +33,8 @@ pub struct CliOptions {
     framerate: Option<f32>,
 
     /// Dark mode - invert colors (default: false)
-    #[arg(long, name = "dark-mode")]
-    dark_mode: bool,
+    //#[arg(long, name = "dark-mode")]
+    //dark_mode: bool,
 
     /// Show cursor (default: false)
     #[arg(long, name = "show-cursor")]
@@ -45,7 +45,8 @@ pub struct CliOptions {
 pub struct ClientOptions {
     pub remarkable_ip: String,
     pub ssh_key: Option<PathBuf>,
-    pub dark_mode: bool,
+    // TODO: implement dark mode
+    // pub dark_mode: bool,
     pub tcp_port: u16,
     pub show_cursor: bool,
     pub framerate: f32,
@@ -82,7 +83,7 @@ impl From<CliOptions> for ClientOptions {
                 },
                 DEFAULT_FRAMERATE,
             ),
-            dark_mode: resolve_boolean_option(value.dark_mode, "REMARKABLE_DARK_MODE", false),
+            //dark_mode: resolve_boolean_option(value.dark_mode, "REMARKABLE_DARK_MODE", false),
             show_cursor: resolve_boolean_option(value.show_cursor, "REMARKABLE_SHOW_CURSOR", false),
         }
     }
@@ -136,10 +137,11 @@ fn resolve_with<T>(
         "read environment variable '{}': {:?}",
         variable_name, env_string,
     );
-    parse(env_string.unwrap_or_else(|_| panic!("could not get environment varialbe '{}'",
-        variable_name)))
-    .unwrap_or_else(|_| panic!("could not parse environemt variable '{}'",
-        variable_name))
+    parse(
+        env_string
+            .unwrap_or_else(|_| panic!("could not get environment varialbe '{}'", variable_name)),
+    )
+    .unwrap_or_else(|_| panic!("could not parse environemt variable '{}'", variable_name))
 }
 
 fn resolve_with_optional<T>(
@@ -161,8 +163,9 @@ fn resolve_with_optional<T>(
             "read environment variable '{}': {}",
             variable_name, env_string,
         );
-        return Some(parse(env_string).unwrap_or_else(|_| panic!("could not parse environemt variable '{}'",
-            variable_name)));
+        return Some(parse(env_string).unwrap_or_else(|_| {
+            panic!("could not parse environemt variable '{}'", variable_name)
+        }));
     }
 
     None

client/src/connection/mod.rs

@@ -120,6 +120,7 @@ impl Connection {
             .map(|_| ())
     }
 
+    #[allow(unused)]
     async fn send_raw(&mut self, msg: Bytes) -> Result<(), Error> {
         self.framed
             .send(msg)

client/src/display/mod.rs

@@ -1,5 +1,3 @@
-
-
 use anyhow::{Context, Error};
 use gstreamer_app::AppSrc;
 use gstreamer_video::VideoFormat;
@@ -9,7 +7,8 @@ use gstreamer::{Pipeline, prelude::*};
 
 #[derive(Debug)]
 pub struct Display {
-    pipeline: Pipeline,
+    #[allow(unused)]
+    pipeline: Pipeline, // only for keeping alive (TODO: check if realy needed)
     appsrc: AppSrc,
 }
 

server/src/config/device.rs

@@ -52,6 +52,7 @@ pub struct DeviceConfig {
 }
 
 impl DeviceConfig {
+    #[allow(unused)]
     pub fn new(version_info: VersionInfo) -> Result<Self, Error> {
         let height = 1872;
         let width = 1404;

server/src/connection/mod.rs

@@ -77,6 +77,7 @@ impl Connection {
         Ok(stream_config)
     }
 
+    #[allow(unused)]
     async fn receive_raw(&mut self) -> Result<BytesMut, Error> {
         self.framed
             .next()

server/src/connection/ssh/mod.rs

@@ -123,7 +123,7 @@ impl Connection {
 fn get_authorized_key_matching_signature(
     token: &AuthentificationToken,
     signature: &SshSig,
-    authorized_keys: &Vec<Entry>,
+    authorized_keys: &[Entry],
 ) -> Option<PublicKey> {
     authorized_keys
         .iter()

server/src/connection/video.rs

@@ -1,7 +1,6 @@
 use std::time::Duration;
 
 use anyhow::{Context, Error};
-use futures::SinkExt;
 use lz4_flex::compress_prepend_size;
 use tokio::time::{MissedTickBehavior, interval};
 use tracing::{debug, trace};

server/src/framebuffer/process.rs

@@ -23,7 +23,7 @@ fn get_process() -> Result<Process, Error> {
 
     let process = processes.next().context("no xochitl process found")?;
 
-    if let Some(_) = processes.next() {
+    if processes.next().is_some() {
         return Err(anyhow!("found more than one xochitl process"));
     }
 
@@ -37,18 +37,17 @@ fn get_framebuffer_offset_in_process_memory(process: &Process) -> Result<usize,
     let framebuffer_path_name =
         MMapPath::from("/dev/fb0").context("could not build framebuffer path name")?;
 
-    let matches_path_name = |m: &&MemoryMap| m.pathname == framebuffer_path_name;
+    let matches_path_name = |m: &MemoryMap| m.pathname == framebuffer_path_name;
 
     let maps = process.maps().context("could not get process maps")?;
-
     let mut maps = maps.iter().skip_while(|m| !matches_path_name(m)).skip(1);
 
     let framebuffer_map = maps.next().expect("found no framebuffer map");
+    let offset = framebuffer_map.address.0 as usize;
 
-    if maps.find(matches_path_name).is_some() {
+    if maps.any(matches_path_name) {
         return Err(anyhow!("found more than one framebuffer map"));
     }
 
-    let offset = framebuffer_map.address.0 as usize;
     Ok(offset)
 }

server/src/main.rs

@@ -13,7 +13,6 @@ use tracing::{error, info};
 use tracing_subscriber::{Registry, fmt, layer::SubscriberExt};
 
 use connection::{Connection, video::VideoConnection};
-use version::VersionInfo;
 
 #[tokio::main]
 async fn main() -> Result<(), Error> {