-
Notifications
You must be signed in to change notification settings - Fork 27
Description
These are not exported, but could be useful to users, particularly those working with multiple issue dates.
Before we do so, however, we should address Ryan's comments:
This will return a
covidcast_signaldata frame with scrambled rows. Would it be worth reordering? This doesn't affect any of our downstream uses like plotting or correlations, but may confuse a user if they calllatest_issue()directly.As far as I understand,
latest_issue()doesn't check the class? So it could in principle be applied to acovidcast_signal_longdata frame? And in this case it wouldn't return the right result, since you're masking bygeo_valueandtime_valuein the call todplyr::distinct(). Thus I would either check the class inlatest_issue()... or includedata_sourceandsignalas masking variables.
For our current uses, neither of these is a problem, but we should fix them before exporting.
I'm tempted to say that reordering the rows is fine -- at least if we document the return order, so users aren't too surprised -- but the second point is definitely a footgun we should fix.