fix: duplicate tabs failed & cannot set options in FF

Author: cnwangjie

src/background.js

@@ -6,6 +6,7 @@ import storage from './common/storage'
 import options from './common/options'
 import migrate from './common/migrate'
 import boss from './common/service/boss'
+import {normalizeList} from './common/list'
 import listManager from './common/listManager'
 import browser from 'webextension-polyfill'
 import {sendMessage} from './common/utils'
@@ -213,6 +214,14 @@ const commandHandler = command => {
   if (PRODUCTION) ga('send', 'event', 'Command used', command)
 }
 
+const fixDirtyData = async () => {
+  const {lists} = await browser.storage.local.get('lists')
+  if (lists) {
+    const cleanLists = lists.filter(_.isPlainObject).map(normalizeList)
+    await browser.storage.local.set({lists: cleanLists})
+  }
+}
+
 const init = async () => {
   logger.init()
   await listManager.init()
@@ -305,6 +314,7 @@ const init = async () => {
     }
   })
   await migrate()
+  await fixDirtyData()
   await boss.init()
 }
 

src/common/listManager.js

@@ -71,12 +71,12 @@ const compressOps = ops => {
   console.debug('[listManager] compress ops: (after)', finalOps)
   return finalOps
 }
-const saveStorage = _.debounce(async () => {
+const saveStorage = _.throttle(async () => {
   cache.ops = compressOps(cache.ops)
   await browser.storage.local.set(cache)
   cache.lists = cache.ops = null
   await sendMessage({refresh: true})
-}, 5000)
+}, 1000)
 const manager = {}
 // lists modifier (return true if need to add ops)
 manager.modifiers = {

src/common/tabs.js

@@ -69,7 +69,6 @@ const storeTabs = async (tabs, listIndex) => {
   if (listIndex == null) {
     const newList = createNewTabList({tabs})
     if (opts.pinNewList) newList.pinned = true
-    lists.unshift(newList)
     await listManager.addList(newList)
   } else {
     const list = lists[listIndex]

src/page/main/DetailList.vue

@@ -525,7 +525,7 @@ export default {
       const changedLists = []
       items.forEach(({listIndex, tabIndex}) => {
         changedLists.push(listIndex)
-        this.addTab([listIndex, tabIndex, this.lists[listIndex].tabs[tabIndex]])
+        this.addTab([listIndex, this.lists[listIndex].tabs[tabIndex]])
       })
       this.tabMoved(changedLists)
     },

src/page/main/Options.vue

@@ -128,8 +128,9 @@ export default {
       console.log(1)
       console.log(key, value)
       // when type of option is string options can not be set correctly after first storage.setOptions() called
-      await storage.setOptions(this.opts) // eslint-disable-line
-      await storage.setOptions(this.opts) // eslint-disable-line
+      const opts = _.clone(this.opts) // eslint-disable-line
+      await storage.setOptions(opts)
+      await storage.setOptions(opts)
       console.log(2)
       await sendMessage({optionsChanged: {[key]: value}})
     }, 100),

webpack.config.js

@@ -21,6 +21,7 @@ const opts = module.exports = {
     content: './src/content.js',
     exchanger: './src/exchanger.js',
   },
+  devtool: 'source-map',
   output: {
     path: resolve('dist'),
     filename : '[name].js',
@@ -67,6 +68,7 @@ const opts = module.exports = {
       name: true,
       minChunks: Infinity,
     },
+    minimizer: [],
   },
   resolve: {
     extensions: ['.js', '.vue', '.json'],
@@ -132,12 +134,10 @@ const opts = module.exports = {
 }
 
 if (opts.mode === 'production') {
-  opts.plugins.push(new UglifyJsPlugin({
+  opts.optimization.minimizer.push(new UglifyJsPlugin({
     uglifyOptions: {
-      parallel: 4,
-      compress: {
-        drop_console: true,
-      }
+      parallel: true,
+      cache: true,
     }
   }))
 }