[BUGFIX] Prevent upgrade wizard from crashing when cruser_id field has been removed, resolves #381

Author: fsuter

ChangeLog

@@ -1,6 +1,7 @@
 2025-07-23 Francois Suter (Idéative)  <typo3@ideative.ch>
 
     * Consider only live records in mapping utility, resolves #384
+    * Prevent upgrade wizard from crashing when cruser_id field has been removed, resolves #381
 
 2025-06-07 Francois Suter (Idéative)  <typo3@ideative.ch>
 

Classes/Updates/LogUsernameMigration.php

@@ -85,11 +85,28 @@ public function executeUpdate(): bool
         return true;
     }
 
+    /**
+     * Ensure that the cruser_id field is still there (the user might have already dropped it)
+     */
     public function updateNecessary(): bool
     {
-        // It's hard to check whether an update is really necessary or not, and since the implications
-        // are minimal, let's just always do it
-        return true;
+        $connection = GeneralUtility::makeInstance(ConnectionPool::class)->getConnectionForTable(self::TABLE_NAME);
+        try {
+            $result = $connection->executeQuery(
+                sprintf(
+                    'SHOW COLUMNS FROM %s;',
+                    self::TABLE_NAME
+                )
+            );
+            while ($row = $result->fetchAssociative()) {
+                if ($row['Field'] === 'cruser_id') {
+                    return true;
+                }
+            }
+        } catch (\Throwable $e) {
+            return false;
+        }
+        return false;
     }
 
     public function getPrerequisites(): array