sql: remove wrapping single quotes in output of ltree2text #156485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgartner
requested review from
a team and
michae2
and removed request for
a team
|
This change is |
yuzefovich
approved these changes
Oct 29, 2025
There was a problem hiding this comment.
Nice finds!
@yuzefovich reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @michae2 and @mw5h)
mw5h
reviewed
Oct 29, 2025
Fixes cockroachdb#156479 Release note (bug fix): A bug has been fix with the `ltree2text` built-in function in which the returned `TEXT` value was incorrectly wrapped with single quotes. This bug has been present since the `ltree2text` built-in was introduced in v25.4.0.
mgartner
force-pushed
the
156479-ltree2text-fix
branch
2 times, most recently
from
459bce1 to
7d1a619
Compare
The second commit was causing problems, so I've backed it out. |
|
TFTRs! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #156479
Release note (bug fix): A bug has been fix with the
ltree2textbuilt-in function in which the returned
TEXTvalue was incorrectlywrapped with single quotes. This bug has been present since the
ltree2textbuilt-in was introduced in v25.4.0.