scbuild: update stub method for isV261Active #156505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version has been created, so we can fix this function now. Release note: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
fqazi
approved these changes
Oct 30, 2025
There was a problem hiding this comment.
@fqazi reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @shghasemi)
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 30, 2025
156486: spanconfig: version gate meta1/meta2 split point in spanconfig r=iskettaneh a=iskettaneh This commit adds a version gate around the spanconfig split point between meta1 and meta2 to avoid scenarios during a rolling upgrade where the job switches back and forth between a v25.4 and a v26.1 versions, which could result in the split point be created a removed multiple times. This was originally done in #119594. Fixes: #119421 Release note: None 156505: scbuild: update stub method for isV261Active r=rafiss a=rafiss The version has been created, so we can fix this function now. Epic: None Release note: None 156510: *: remove stale skips of test tenant randomization r=yuzefovich a=yuzefovich I've audited all places where we disable test tenants in some way and found a handful of places where an already closed issue was used as a reference for why a particular test disables test tenants. This commit removes those now-stale skips. Epic: CRDB-48945 Release note: None 156565: logictest: reduce data set in cursor test r=yuzefovich a=yuzefovich We've seen a few failures on `cursor` logic test under race which seems to be due to node overload / timeout. My hypothesis is it's due to metamorphic randomization, and I found one spot where we use 10k rows in the table, but I don't think we need this much. This commit reduces the row count to just 10 in hopes of eliminating the flake under race. Fixes: #155609. Release note: None Co-authored-by: iskettaneh <[email protected]> Co-authored-by: Rafi Shamim <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]>
|
Build failed (retrying...): |
craig bot
pushed a commit
that referenced
this pull request
Oct 30, 2025
156505: scbuild: update stub method for isV261Active r=rafiss a=rafiss The version has been created, so we can fix this function now. Epic: None Release note: None 156510: *: remove stale skips of test tenant randomization r=yuzefovich a=yuzefovich I've audited all places where we disable test tenants in some way and found a handful of places where an already closed issue was used as a reference for why a particular test disables test tenants. This commit removes those now-stale skips. Epic: CRDB-48945 Release note: None Co-authored-by: Rafi Shamim <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]>
|
Build failed (retrying...): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version has been created, so we can fix this function now.
Epic: None
Release note: None