Use `ring` instead of `rsa` for ADB direct authentication

[cocool97]

Ring library is already used as a dependency of rustls, and does not have known vulnerabilities.

[pavi2410]

aws-lc-sys crate, which has a dependency on the rsa crate used by adb_client crate, fails to compile on Windows 11 due to missing cmake external dependency. I do not want to install cmake unnecessarily.

error: failed to run custom build command for `aws-lc-sys v0.23.1`

Caused by:
  process didn't exit successfully: `D:\Projects\Kodular\Starter\src-tauri\target\debug\build\aws-lc-sys-52ee19cb97b7a6c1\build-script-main` (exit code: 101)
  --- stdout
  cargo:rerun-if-env-changed=AWS_LC_SYS_NO_PREFIX
  cargo:rerun-if-env-changed=AWS_LC_SYS_PREGENERATING_BINDINGS
  cargo:rerun-if-env-changed=AWS_LC_SYS_EXTERNAL_BINDGEN
  cargo:rerun-if-env-changed=AWS_LC_SYS_NO_ASM
  cargo:rerun-if-env-changed=AWS_LC_SYS_CFLAGS
  cargo:rerun-if-env-changed=AWS_LC_SYS_PREBUILT_NASM
  cargo:rerun-if-env-changed=AWS_LC_SYS_C_STD
  cargo:rustc-cfg=x86_64_pc_windows_msvc
  cargo:rerun-if-env-changed=AWS_LC_SYS_CMAKE_BUILDER
  cargo:rerun-if-env-changed=AWS_LC_SYS_STATIC
  default_for Target: 'x86_64-pc-windows-msvc'
  cargo:rerun-if-env-changed=AWS_LC_SYS_STATIC
  cargo:rerun-if-env-changed=CMAKE

  --- stderr
  Missing dependency: cmake
  thread 'main' panicked at C:\Users\Pavitra\.cargo\registry\src\index.crates.io-6f17d22bba15001f\aws-lc-sys-0.23.1\builder/main.rs:372:40:
  called `Result::unwrap()` on an `Err` value: "Required build dependency is missing. Halting build."
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Related: rustls/rustls#2133

[cocool97]

Installing cmake doesn't fix this issue ?

Failing crate is dependency coming from rustls...

[pavi2410]

Installing cmake doesn't fix this issue ?

I got it running after a few restarts... 😂

[diepes]

Trying to build some code using adb_client for windows, the tcp connection seem to pull in a dependency that is not compatible with Windows build. rustls/aws-lc-rs

[pavi2410]

Back on Windows again, and due to cmake missing, it failed to install successfully.

[pavi2410]

Looks fixed in v3 - #144

[cocool97]

We cannot replace (I hope not for long) the rsa crate as there is no replacement library. ring does not support this kind of authentication.

I removed the indirect aws_lc_rs dependency in #181 if favor of ring so the code should compile on windows.