Skip to content

infra: upgrade circleci version to 2.1#35

Merged
CallMeLeopoldo merged 1 commit into
masterfrom
ls/upgrade-circleci-to-2.1
Jul 3, 2026
Merged

infra: upgrade circleci version to 2.1#35
CallMeLeopoldo merged 1 commit into
masterfrom
ls/upgrade-circleci-to-2.1

Conversation

@CallMeLeopoldo

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CircleCI configuration version from 2 to 2.1. There are no review comments, and I have no feedback to provide on this change.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR successfully updates the CircleCI version to 2.1. However, this upgrade introduces stricter schema validation that is currently violated by the use of a top-level 'references' key. While Codacy indicates the project is 'up to standards', the configuration will fail to parse in CircleCI. This must be addressed before merging to prevent breaking the CI pipeline. Additionally, the PR description is currently empty, providing no context for the upgrade.

About this PR

  • The PR description is empty. Please provide context regarding the upgrade and whether you intend to leverage specific 2.1 features like orbs or executors in this or future PRs.

Test suggestions

  • Validate CircleCI configuration syntax against the 2.1 schema
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Validate CircleCI configuration syntax against the 2.1 schema

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

Comment thread .circleci/config.yml
Comment thread .circleci/config.yml
@CallMeLeopoldo

CallMeLeopoldo commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Maybe the config checker doesn't catch references. This one will definitely stop working in 2 weeks.

How can we say so? Using the in-app config editor tells us the same thing (that the config is valid) and I see no reference of that in the changelog described here

@ricardobernardino2024

Copy link
Copy Markdown
Contributor

Maybe the config checker doesn't catch references. This one will definitely stop working in 2 weeks.

How can we say so? Using the in-app config editor tells us the same thing (that the config is valid) and I see no reference of that in the changelog described here
I was referring to your comment about references and not the references functionality.
I meant that the config checker will return OK in a project referencing a NOK project.

@CallMeLeopoldo CallMeLeopoldo merged commit 3a985b3 into master Jul 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants