fix: refresh menu attributes after settings restore

Author: be-student

CONTRIBUTING.md

@@ -8,3 +8,13 @@ Welcome to work! ("issues")
 ### https://github.com/code-charity/youtube/wiki/Contributing
 you can also just check the (pinned-)issues(, readme & discussion, wiki, ..)  <br><br>
 ### Thanks for caring ♥
+
+
+### Settings restore regression tests
+
+Run `npx jest --runInBand tests/unit/settings-import.test.js` to check file and
+browser-account restores with a delayed storage callback. Restores must wait for
+the batch write before updating the cache, notifying listeners, or closing the
+importer. A successful restore emits `storage-set` after populating the cache so
+the open menu refreshes its theme and visibility attributes through the listener
+in `menu/index.js`. Storage errors must leave the cache and importer unchanged.

menu/functions.js

@@ -141,6 +141,8 @@ extension.applyImportedSettings = function (data, callback) {
 
 		// Populate the cache before notifying subscribers.
 		Object.assign(satus.storage.data, data);
+		// Preserve the write notification used to refresh the open menu's attributes.
+		satus.events.trigger('storage-set');
 		satus.events.trigger('storage-import');
 
 		if (callback) callback();

tests/unit/settings-import.test.js

@@ -101,6 +101,42 @@ describe('Settings import persistence', () => {
 			.toBeLessThan(context.close.mock.invocationCallOrder[0]);
 	});
 
+	test('updates menu attributes after a browser-account restore persists', () => {
+		const listeners = {};
+		const attributes = {};
+		const modalProvider = {close: jest.fn()};
+		context.extension.skeleton.rendered = {
+			setAttribute: (key, value) => { attributes[key] = value; },
+			removeAttribute: (key) => { delete attributes[key]; }
+		};
+		context.satus.storage.data = {theme: 'light'};
+		context.satus.storage.get = (key) => context.satus.storage.data[key];
+		context.satus.storage.import = (callback) => callback(context.satus.storage.data);
+		context.satus.locale = {import: (language, callback) => callback()};
+		context.satus.parentify = jest.fn();
+		context.satus.isset = (value) => value !== undefined && value !== null;
+		context.satus.events.on = (event, listener) => { listeners[event] = listener; };
+		context.satus.events.trigger.mockImplementation((event) => {
+			if (listeners[event]) listeners[event]();
+		});
+		context.location.href = 'moz-extension://test/menu/index.html';
+		vm.runInNewContext(
+			fs.readFileSync(path.join(__dirname, '../../menu/index.js'), 'utf8'),
+			context
+		);
+
+		expect(attributes.theme).toBe('light');
+		context.extension.pullSettings();
+		modal.buttons.ok.on.click.call({modalProvider});
+		expect(attributes.theme).toBe('light');
+		expect(modalProvider.close).not.toHaveBeenCalled();
+
+		storageCallback();
+
+		expect(attributes.theme).toBe('dark');
+		expect(modalProvider.close).toHaveBeenCalledTimes(1);
+	});
+
 	test('keeps browser-account restore open until the local write completes', () => {
 		const modalProvider = {close: jest.fn()};