Skip to content

Commit cf9b05f

Browse files
committed
Update spec fixtures
Update spec fixtures to use simplified `Gemfile` examples and update spec logic to verify that all expected issues are present in engine-generated issues. Now that we're correctly referencing the updated database, new vulnerabilities may show up.
1 parent ffcce20 commit cf9b05f

File tree

8 files changed

+447
-646
lines changed

8 files changed

+447
-646
lines changed

spec/cc/engine/bundler_audit/analyzer_spec.rb

+7-3
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,19 @@ module CC::Engine::BundlerAudit
1515

1616
issues = analyze_directory(directory)
1717

18-
expect(issues).to eq(expected_issues("unpatched_versions"))
18+
expected_issues("unpatched_versions").each do |expected_issue|
19+
expect(issues).to include(expected_issue)
20+
end
1921
end
2022

2123
it "emits issues for insecure sources in Gemfile.lock" do
22-
directory = fixture_directory("insecure_source")
24+
directory = fixture_directory("insecure_sources")
2325

2426
issues = analyze_directory(directory)
2527

26-
expect(issues).to eq(expected_issues("insecure_source"))
28+
expected_issues("insecure_sources").each do |expected_issue|
29+
expect(issues).to include(expected_issue)
30+
end
2731
end
2832

2933
it "logs to stderr when we encounter an unsupported vulnerability" do

spec/fixtures/insecure_source/Gemfile.lock

-329
This file was deleted.
+7
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
source "http://rubygems.org"
2+
3+
gem "rails", "~> 4.2.5.1"
4+
gem "devise", "~> 3.5.4"
5+
gem "jquery-rails", "~> 3.1.3"
6+
gem "uglifier", "~> 2.7.2"
7+
gem "simple_form", github: "plataformatec/simple_form"

0 commit comments

Comments
 (0)