Skip to content

Commit 77e3337

Browse files
Remove docker login step from circle yml (#329)
This removes the docker login step from our Circle yml. The idea is that this is pulling the parser image, which was private when we added this step. However, the parser image is now public. This is also blocking OSS contributions from users who have forked duplication, since Circle fails at this step on forks. Co-authored-by: Max Jacobson <[email protected]>
1 parent 0646b13 commit 77e3337

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

Diff for: circle.yml

-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ dependencies:
1212
--env GCR_JSON_KEY
1313
--volume /var/run/docker.sock:/var/run/docker.sock
1414
codeclimate/patrick pull || true
15-
- docker login --username "$DOCKER_USERNAME" --password "$DOCKER_PASSWORD" --email "$DOCKER_EMAIL"
1615
- make image
1716

1817
test:

0 commit comments

Comments
 (0)