PHP: filter out use statements by default

Author: wfleming

Diff for: lib/cc/engine/analyzers/php/main.rb

@@ -15,6 +15,9 @@ class Main < CC::Engine::Analyzers::Base
             "**/*.php",
           ].freeze
           DEFAULT_MASS_THRESHOLD = 28
+          DEFAULT_FILTERS = [
+            "(use ___)".freeze,
+          ].freeze
           POINTS_PER_OVERAGE = 100_000
 
           def transform_sexp(sexp)
@@ -32,6 +35,10 @@ def process_file(path)
           def php_parser
             ::CC::Engine::Analyzers::Php::Parser
           end
+
+          def default_filters
+            DEFAULT_FILTERS.map { |filter| Sexp::Matcher.parse filter }
+          end
         end
       end
     end

Diff for: spec/cc/engine/analyzers/php/main_spec.rb

@@ -165,31 +165,31 @@
     end
 
     it "ignores namespace and use declarations" do
-      create_source_file("foo.php", <<-EOF)
-<?php
-namespace KeepClear\\Http\\Controllers\\API\\V1;
-use Illuminate\\Http\\Request;
-use KeepClear\\Http\\Controllers\\Controller;
-use KeepClear\\Models\\Comment;
-use KeepClear\\Models\\User;
-use KeepClear\\Models\\Asset;
-use KeepClear\\Traits\\Controllers\\ApiFilter;
-use KeepClear\\Traits\\Controllers\\ApiParseBody;
-use KeepClear\\Traits\\Controllers\\ApiException;
-      EOF
-
-      create_source_file("bar.php", <<-EOF)
-<?php
-namespace KeepClear\\Http\\Controllers\\API\\V1;
-use Illuminate\\Http\\Request;
-use KeepClear\\Http\\Controllers\\Controller;
-use KeepClear\\Models\\Comment;
-use KeepClear\\Models\\User;
-use KeepClear\\Models\\Asset;
-use KeepClear\\Traits\\Controllers\\ApiFilter;
-use KeepClear\\Traits\\Controllers\\ApiParseBody;
-use KeepClear\\Traits\\Controllers\\ApiException;
-      EOF
+      create_source_file("foo.php", <<~EOPHP)
+      <?php
+      namespace KeepClear\\Http\\Controllers\\API\\V1;
+      use Illuminate\\Http\\Request;
+      use KeepClear\\Http\\Controllers\\Controller;
+      use KeepClear\\Models\\Comment;
+      use KeepClear\\Models\\User;
+      use KeepClear\\Models\\Asset;
+      use KeepClear\\Traits\\Controllers\\ApiFilter;
+      use KeepClear\\Traits\\Controllers\\ApiParseBody;
+      use KeepClear\\Traits\\Controllers\\ApiException;
+      EOPHP
+
+      create_source_file("bar.php", <<~EOPHP)
+      <?php
+      namespace KeepClear\\Http\\Controllers\\API\\V1;
+      use Illuminate\\Http\\Request;
+      use KeepClear\\Http\\Controllers\\Controller;
+      use KeepClear\\Models\\Comment;
+      use KeepClear\\Models\\User;
+      use KeepClear\\Models\\Asset;
+      use KeepClear\\Traits\\Controllers\\ApiFilter;
+      use KeepClear\\Traits\\Controllers\\ApiParseBody;
+      use KeepClear\\Traits\\Controllers\\ApiException;
+      EOPHP
 
       issues = run_engine(engine_conf).strip.split("\0")
       expect(issues).to be_empty