Update rubocop to 1.63.5

- General bundle update.
- Update the docs too.
- Add `require "ostruct"` to a couple test files using OpenStruct.

Author: BrianHawley

Gemfile

@@ -5,14 +5,15 @@ source 'https://rubygems.org'
 gem "activesupport", require: false
 gem "parser"
 gem "pry", require: false
-gem "rubocop", "1.62.1", require: false
+gem "rubocop", "1.63.5", require: false
 gem "rubocop-graphql", require: false
 gem "rubocop-i18n", require: false
 gem "rubocop-minitest", require: false
 gem "rubocop-performance", require: false
 gem "rubocop-rails", require: false
 gem "rubocop-rake", require: false
 gem "rubocop-rspec", require: false
+gem "rubocop-rspec_rails", require: false
 gem "rubocop-sequel", require: false
 gem "rubocop-shopify", require: false
 gem "rubocop-sorbet", require: false

Gemfile.lock

@@ -13,31 +13,31 @@ GEM
       tzinfo (~> 2.0)
     ast (2.4.2)
     base64 (0.2.0)
-    bigdecimal (3.1.7)
+    bigdecimal (3.1.8)
     coderay (1.1.3)
     concurrent-ruby (1.2.3)
     connection_pool (2.4.1)
     diff-lcs (1.5.1)
     drb (2.2.1)
-    i18n (1.14.4)
+    i18n (1.14.5)
       concurrent-ruby (~> 1.0)
-    json (2.7.1)
+    json (2.7.2)
     language_server-protocol (3.17.0.3)
-    method_source (1.0.0)
+    method_source (1.1.0)
     minitest (5.22.3)
     mutex_m (0.2.0)
     parallel (1.24.0)
-    parser (3.3.0.5)
+    parser (3.3.1.0)
       ast (~> 2.4.1)
       racc
     pry (0.14.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
     racc (1.7.3)
-    rack (3.0.9.1)
+    rack (3.0.11)
     rainbow (3.1.1)
-    rake (13.1.0)
-    regexp_parser (2.9.0)
+    rake (13.2.1)
+    regexp_parser (2.9.1)
     rexml (3.2.6)
     rspec (3.13.0)
       rspec-core (~> 3.13.0)
@@ -48,11 +48,11 @@ GEM
     rspec-expectations (3.13.0)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-mocks (3.13.0)
+    rspec-mocks (3.13.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
     rspec-support (3.13.1)
-    rubocop (1.62.1)
+    rubocop (1.63.5)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
@@ -63,43 +63,46 @@ GEM
       rubocop-ast (>= 1.31.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.31.2)
-      parser (>= 3.3.0.4)
+    rubocop-ast (1.31.3)
+      parser (>= 3.3.1.0)
     rubocop-capybara (2.20.0)
       rubocop (~> 1.41)
     rubocop-factory_bot (2.25.1)
       rubocop (~> 1.41)
-    rubocop-graphql (1.5.0)
+    rubocop-graphql (1.5.1)
       rubocop (>= 0.90, < 2)
     rubocop-i18n (3.0.0)
       rubocop (~> 1.0)
     rubocop-minitest (0.35.0)
       rubocop (>= 1.61, < 2.0)
       rubocop-ast (>= 1.31.1, < 2.0)
-    rubocop-performance (1.20.2)
+    rubocop-performance (1.21.0)
       rubocop (>= 1.48.1, < 2.0)
-      rubocop-ast (>= 1.30.0, < 2.0)
-    rubocop-rails (2.24.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
+    rubocop-rails (2.24.1)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)
       rubocop-ast (>= 1.31.1, < 2.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
-    rubocop-rspec (2.27.1)
+    rubocop-rspec (2.29.2)
       rubocop (~> 1.40)
       rubocop-capybara (~> 2.17)
       rubocop-factory_bot (~> 2.22)
+      rubocop-rspec_rails (~> 2.28)
+    rubocop-rspec_rails (2.28.3)
+      rubocop (~> 1.40)
     rubocop-sequel (0.3.4)
       rubocop (~> 1.0)
     rubocop-shopify (2.15.1)
       rubocop (~> 1.51)
-    rubocop-sorbet (0.7.8)
+    rubocop-sorbet (0.8.3)
       rubocop (>= 0.90.0)
     rubocop-thread_safety (0.5.1)
       rubocop (>= 0.90.0)
     ruby-progressbar (1.13.0)
-    test-prof (1.3.2)
+    test-prof (1.3.3)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.5.0)
@@ -113,14 +116,15 @@ DEPENDENCIES
   pry
   rake
   rspec
-  rubocop (= 1.62.1)
+  rubocop (= 1.63.5)
   rubocop-graphql
   rubocop-i18n
   rubocop-minitest
   rubocop-performance
   rubocop-rails
   rubocop-rake
   rubocop-rspec
+  rubocop-rspec_rails
   rubocop-sequel
   rubocop-shopify
   rubocop-sorbet

config/contents/lint/debugger.md

@@ -22,6 +22,11 @@ Lint/Debugger:
       MyDebugger.debug_this
 ```
 
+Some gems also ship files that will start a debugging session when required,
+for example `require 'debug/start'` from `ruby/debug`. These requires can
+be configured through `DebuggerRequires`. It has the same structure as
+`DebuggerMethods`, which you can read about above.
+
 ### Example:
 
     # bad (ok during development)
@@ -56,4 +61,10 @@ Lint/Debugger:
 
     def some_method
       my_debugger
-    end
+    end
+
+### Example: DebuggerRequires: [my_debugger/start]
+
+    # bad (ok during development)
+
+    require 'my_debugger/start'

config/contents/style/collection_compact.md

@@ -15,9 +15,7 @@ when the receiver is a hash object.
 ### Example:
     # bad
     array.reject(&:nil?)
-    array.delete_if(&:nil?)
     array.reject { |e| e.nil? }
-    array.delete_if { |e| e.nil? }
     array.select { |e| !e.nil? }
     array.grep_v(nil)
     array.grep_v(NilClass)
@@ -27,7 +25,9 @@ when the receiver is a hash object.
 
     # bad
     hash.reject!(&:nil?)
+    array.delete_if(&:nil?)
     hash.reject! { |k, v| v.nil? }
+    array.delete_if { |e| e.nil? }
     hash.select! { |k, v| !v.nil? }
 
     # good

config/contents/style/format_string.md

@@ -19,24 +19,24 @@ format('%s', [1, 2, 3]) #=> '[1, 2, 3]'
 
 ### Example: EnforcedStyle: format (default)
     # bad
-    puts sprintf('%10s', 'hoge')
-    puts '%10s' % 'hoge'
+    puts sprintf('%10s', 'foo')
+    puts '%10s' % 'foo'
 
     # good
-    puts format('%10s', 'hoge')
+    puts format('%10s', 'foo')
 
 ### Example: EnforcedStyle: sprintf
     # bad
-    puts format('%10s', 'hoge')
-    puts '%10s' % 'hoge'
+    puts format('%10s', 'foo')
+    puts '%10s' % 'foo'
 
     # good
-    puts sprintf('%10s', 'hoge')
+    puts sprintf('%10s', 'foo')
 
 ### Example: EnforcedStyle: percent
     # bad
-    puts format('%10s', 'hoge')
-    puts sprintf('%10s', 'hoge')
+    puts format('%10s', 'foo')
+    puts sprintf('%10s', 'foo')
 
     # good
-    puts '%10s' % 'hoge'
+    puts '%10s' % 'foo'

config/contents/style/map_into_array.md

@@ -0,0 +1,43 @@
+Checks for usages of `each` with `<<`, `push`, or `append` which
+can be replaced by `map`.
+
+If `PreferredMethods` is configured for `map` in `Style/CollectionMethods`,
+this cop uses the specified method for replacement.
+
+NOTE: The return value of `Enumerable#each` is `self`, whereas the
+return value of `Enumerable#map` is an `Array`. They are not autocorrected
+when a return value could be used because these types differ.
+
+NOTE: It only detects when the mapping destination is a local variable
+initialized as an empty array and referred to only by the pushing operation.
+This is because, if not, it's challenging to statically guarantee that the
+mapping destination variable remains an empty array:
+
+```ruby
+ret = []
+src.each { |e| ret << e * 2 } # `<<` method may mutate `ret`
+
+dest = []
+src.each { |e| dest << transform(e, dest) } # `transform` method may mutate `dest`
+```
+
+### Safety:
+
+This cop is unsafe because not all objects that have an `each`
+method also have a `map` method (e.g. `ENV`). Additionally, for calls
+with a block, not all objects that have a `map` method return an array
+(e.g. `Enumerator::Lazy`).
+
+### Example:
+    # bad
+    dest = []
+    src.each { |e| dest << e * 2 }
+    dest
+
+    # good
+    dest = src.map { |e| e * 2 }
+
+    # good - contains another operation
+    dest = []
+    src.each { |e| dest << e * 2; puts e }
+    dest

config/contents/style/send.md

@@ -2,9 +2,9 @@ Checks for the use of the send method.
 
 ### Example:
     # bad
-    Foo.send(:bar)
-    quuz.send(:fred)
+    Foo.send(bar)
+    quuz.send(fred)
 
     # good
-    Foo.__send__(:bar)
-    quuz.public_send(:fred)
+    Foo.__send__(bar)
+    quuz.public_send(fred)

config/contents/style/special_global_vars.md

@@ -54,9 +54,8 @@ true, replacing perl-style variables with english variables will break.
 
 ### Example: EnforcedStyle: use_builtin_english_names
 
-Like `use_perl_names` but allows builtin global vars.
-
     # good
+    # Like `use_perl_names` but allows builtin global vars.
     puts $LOAD_PATH
     puts $LOADED_FEATURES
     puts $PROGRAM_NAME

spec/cc/engine/issue_spec.rb

@@ -1,5 +1,6 @@
 require "spec_helper"
 require "cc/engine/issue"
+require "ostruct"
 
 module CC::Engine
   describe Issue do

spec/cc/engine/rubocop_spec.rb

@@ -1,5 +1,6 @@
 require "spec_helper"
 require "cc/engine/rubocop"
+require "ostruct"
 require "tmpdir"
 
 module CC::Engine