Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Git files (network) not found when run from a non-git folder. #624

Open
Flamefire opened this issue Feb 14, 2025 · 1 comment
Open
Assignees
Labels
Area: Report Upload Issues with pre-ingest report uploading bug Something isn't working Eng Area: CLI: General high High Priority Issues (to be fixed within 2 sprints)

Comments

@Flamefire
Copy link
Contributor

Describe the bug

I tried uploading a coverage file from GitHub Actions and noticed that the path fixup didn't work anymore.
I traced that to this issue: GitVersioningSystem.is_available only returns True if the current directory is a git repository

So even if --network-root-folder was specified and set to a git repository it will not be detected because GitVersioningSystem is not used as it fails if the current folder is not a git repo and hence git rev-parse --show-toplevel fails to early.

To Reproduce
Steps to reproduce the behavior:

  1. Go to an empty folder
  2. run the app with --network-root-folder set correctly
  3. See that "relevant files" is empty and fixups are not done
@Flamefire Flamefire added the bug Something isn't working label Feb 14, 2025
@thomasrockhu-codecov
Copy link
Contributor

@Flamefire nice catch, I'll work on a fix next week

@thomasrockhu-codecov thomasrockhu-codecov self-assigned this Feb 14, 2025
@thomasrockhu-codecov thomasrockhu-codecov added high High Priority Issues (to be fixed within 2 sprints) Area: Report Upload Issues with pre-ingest report uploading Eng Area: CLI: General labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Report Upload Issues with pre-ingest report uploading bug Something isn't working Eng Area: CLI: General high High Priority Issues (to be fixed within 2 sprints)
Projects
None yet
Development

No branches or pull requests

2 participants