Skip to content

Set up ruff, add CI check #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Set up ruff, add CI check #1996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8472968
Set up ruff, add CI check
chiroptical Nov 19, 2025
d5532fd
We should also run pytest
chiroptical Nov 19, 2025
ec04c4e
Run prettier on repo-checks.yml
chiroptical Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/repo-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,20 @@ name: Repo Checks
on: ["push", "pull_request"]

jobs:
check_python_quality:
name: Code Quality
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: actions/setup-python@v6
with:
python-version: "3.11"
- run: pip install -r llm/requirements.txt
- run: ruff check llm/
- run: ruff format --check llm/
Comment on lines +16 to +17
Copy link
Collaborator Author

@chiroptical chiroptical Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we like to do this on the analysis/ directory too?

Copy link
Collaborator

@nesanders nesanders Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per our Zoom discussion, lets scope it to llm/ since that's where we expect all of our python analysis scripts to live for now and we do not want to apply ruff to ipynb's that live elsewhere.

- run: pytest llm/

check_code_quality:
name: Code Quality
runs-on: ubuntu-latest
Expand Down
Loading