Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DO NOT MERGE
This is currently blocked on a styled-components upgrade
According to https://react.dev/blog/2024/04/25/react-19-upgrade-guide, this was put in place to help people migrate to 19. It is supposed to add additional warnings for changes in 19.
Testing
First, I noticed some warnings in
yarn build:prodbut they do not change frommainto this branch, e.g.Before
After
To additionally verify that no changes need to be made I figure I could try
npx codemod@latest react/19/migration-recipeto see if nothing changes. It absolutely doesn't change anything!Checklist
firestore.indexes.json(Please do not only create indexes through the Firebase Web UI, even though the error messages may reccommend it - indexes created this way may be obliterated by subsequent deploys)Screenshots
Add some screenshots highlighting your changes.
Known issues
If you've run against limitations or caveats, include them here. Include follow-up issues as well.
Steps to test/reproduce
For each feature or bug fix, create a step by step list for how a reviewer can test it out. E.g.: