Fix: UI properties were being sent when spinning up a new job

Signed-off-by: worksofliam <[email protected]>

Author: worksofliam

src/connection/sqlJob.ts

@@ -151,6 +151,7 @@ export class OldSQLJob extends SQLJob {
 
     const props = Object
       .keys(this.options)
+      .filter(prop => this.options[prop] !== `` && this.options[prop] !== null && this.options[prop] !== undefined) // 0 is valid
       .map(prop => {
         if (Array.isArray(this.options[prop])) {
           return `${prop}=${(this.options[prop] as string[]).join(`,`)}`;

src/views/jobManager/jobManagerView.ts

@@ -36,6 +36,11 @@ export class JobManagerView implements TreeDataProvider<any> {
       }),
 
       vscode.commands.registerCommand(`vscode-db2i.jobManager.newJob`, async (options?: JDBCOptions, name?: string) => {
+        if (options && 'contextValue' in options) {
+          // This happens because the button is clickable from the Job Manager title bar.
+          options = undefined;
+        }
+
         try {
           updateStatusBar({newJob: true});
           await JobManager.newJob(