Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy should allow OPTIONS #7283

Open
code-asher opened this issue Mar 26, 2025 · 0 comments · May be fixed by #7284
Open

Proxy should allow OPTIONS #7283

code-asher opened this issue Mar 26, 2025 · 0 comments · May be fixed by #7284
Labels
bug Something isn't working triage This issue needs to be triaged by a maintainer

Comments

@code-asher
Copy link
Member

code-asher commented Mar 26, 2025 •
edited
Loading

Steps to Reproduce

Send an OPTIONS request to your application through code-server's proxy.

Expected

Should get a 200 or 204 back.

Actual

Gets blocked with a 401 if you have --auth=password, because OPTIONS requests do not include credentials.

Notes

We should return a 200 or 204 for OPTIONS requests without checking auth.
@code-asher code-asher added bug Something isn't working triage This issue needs to be triaged by a maintainer labels Mar 26, 2025
@helgehatt helgehatt linked a pull request Mar 27, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage This issue needs to be triaged by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow OPTIONS requests through domain proxy helgehatt/code-server
1 participant
@code-asher