review

Author: ethanndickson

Diff for: Coder-Desktop/Coder-Desktop/Views/FileSync/FilePicker.swift

@@ -78,10 +78,10 @@ class FilePickerModel: ObservableObject {
     @Published var isLoading: Bool = false
     @Published var error: ClientError?
 
-    let client: Client
+    let client: AgentClient
 
     init(host: String) {
-        client = Client(url: URL(string: "http://\(host):4")!)
+        client = AgentClient(agentHost: host)
     }
 
     func loadRoot() {
@@ -176,7 +176,7 @@ class FilePickerItemModel: Identifiable, ObservableObject {
     // This being a binding is pretty important performance-wise, as it's a struct
     // that would otherwise be recreated every time the the item row is rendered.
     // Removing the binding results in very noticeable lag when scrolling a file tree.
-    @Binding var client: Client
+    @Binding var client: AgentClient
 
     @Published var contents: [FilePickerItemModel]?
     @Published var isLoading = false
@@ -197,7 +197,7 @@ class FilePickerItemModel: Identifiable, ObservableObject {
 
     init(
         name: String,
-        client: Binding<Client>,
+        client: Binding<AgentClient>,
         absolute_path: String,
         path: [String],
         dir: Bool = false,
@@ -237,7 +237,7 @@ class FilePickerItemModel: Identifiable, ObservableObject {
 
 extension LSResponse {
     @MainActor
-    func toModels(client: Binding<Client>, path: [String]) -> [FilePickerItemModel] {
+    func toModels(client: Binding<AgentClient>, path: [String]) -> [FilePickerItemModel] {
         contents.compactMap { file in
             // Filter dotfiles from the picker
             guard !file.name.hasPrefix(".") else { return nil }

Diff for: Coder-Desktop/CoderSDK/AgentClient.swift

@@ -0,0 +1,7 @@
+public struct AgentClient: Sendable {
+    let client: Client
+
+    public init(agentHost: String) {
+        client = Client(url: URL(string: "http://\(agentHost):4")!)
+    }
+}

Diff for: Coder-Desktop/CoderSDK/AgentLS.swift

@@ -1,11 +1,10 @@
-public extension Client {
-    // The Client's URL MUST be set to that of an accessible agent
+public extension AgentClient {
     func listAgentDirectory(_ req: LSRequest) async throws(ClientError) -> LSResponse {
-        let res = try await request("/api/v0/list-directory", method: .post, body: req)
+        let res = try await client.request("/api/v0/list-directory", method: .post, body: req)
         guard res.resp.statusCode == 200 else {
-            throw responseAsError(res)
+            throw client.responseAsError(res)
         }
-        return try decode(LSResponse.self, from: res.data)
+        return try client.decode(LSResponse.self, from: res.data)
     }
 }