Skip to content

Incorporate dynamic workspace suffix into UI #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ThomasK33 opened this issue Mar 6, 2025 · 1 comment · Fixed by #133
Closed

Incorporate dynamic workspace suffix into UI #93

ThomasK33 opened this issue Mar 6, 2025 · 1 comment · Fixed by #133
Assignees
@ethanndickson
Labels
enhancement New feature or request

Comments

@ThomasK33
Copy link
Member

Currently we're hardcoding the .coder suffix in the MenuItemView.
With coder/coder#16828 the HostnameSuffix will become a configurable value, thus we need to read that value and adjust the UI accordingly.
@ThomasK33 ThomasK33 added the enhancement New feature or request label Mar 6, 2025
@matifali
Copy link
Member

matifali commented Mar 6, 2025

I was wondering if we can instead use the same suffix as the CODER_ACCESS_URL. If CODER_WILDCARD_ACCESS_URL is set, we can reuse the wildcard cert for HTTPS apps. I am sure it will conflict with the configured DNS server resolving the CODER_ACCESS_URL and its subdomains.

@ethanndickson ethanndickson self-assigned this Apr 10, 2025
@ethanndickson ethanndickson mentioned this issue Apr 10, 2025
Merged
ethanndickson added a commit that referenced this issue Apr 15, 2025
@ethanndickson
feat: use the deployment's hostname suffix in the UI (#133)
afd9634 
Closes #93.

<img width="272" alt="image" src="https://github.com/user-attachments/assets/54786bea-9d32-432f-9869-5abd42a86516" />


The only time the hostname suffix is used by the desktop app is when an offline workspace needs to be shown in the list, where we naively append `.coder`. This PR sets this appended value to whatever `--workspace-hostname-suffix` is configured to deployment-side.

We read the config value from the deployment when:
- The app is launched, if the user is signed in.
- The user signs in.
- The VPN is started.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanndickson ethanndickson

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use the deployment's hostname suffix in the UI coder/coder-desktop-macos
3 participants
@ThomasK33 @matifali @ethanndickson