feat: add start vpn on launch setting #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasK33
approved these changes
Mar 11, 2025
ethanndickson
force-pushed
the
ethan/start-on-launch-setting
branch
from
e19e213 to
df5447f
Compare
ethanndickson
force-pushed
the
ethan/start-on-launch-setting
branch
from
df5447f to
ea50192
Compare
ethanndickson
force-pushed
the
ethan/start-on-launch-setting
branch
from
ea50192 to
be1bc20
Compare
ethanndickson
added a commit
that referenced
this pull request
Mar 19, 2025
This is a fix for #108. Previously we would start the VPN immediately on launch if the config option was true. This starting of the VPN raced with any concurrent upgrades of the network extension, causing the VPN to be started with a VPN config belonging to the older network extension, and producing a consistent error message:  Instead, we should only start the VPN once we know that the system extension and VPN configuration are installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #104.
On-demand is a pretty big lift - in the meantime we'll add a 'start VPN on launch' config setting.