Skip to content

Commit a282df7

Browse files
committed
fix: use correct URL
1 parent 5d86b9c commit a282df7

File tree

3 files changed

+17
-5
lines changed

3 files changed

+17
-5
lines changed

jfrog/client.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ type Image struct {
101101
}
102102

103103
func (c *client) ResultsURL(img Image, packageID string) string {
104-
return fmt.Sprintf("%s/ui/scans-list/packages-scans/%s/%s/scan-descendants/%s?package_id=%s&version=%s", c.baseURL, img.Repo, img.Package, img.Version, packageID, img.Version)
104+
return fmt.Sprintf("%s/ui/scans-list/packages-scans/%s/scan-descendants/%s?package_id=%s&version=%s", c.baseURL, img.Package, img.Version, packageID, img.Version)
105105
}
106106

107107
func ParseImage(image string) (Image, error) {

reporter/reporter.go

+15-3
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,16 @@ package reporter
33
import (
44
"context"
55
"fmt"
6+
"time"
67

78
"golang.org/x/xerrors"
89

910
"github.com/google/uuid"
1011

1112
"github.com/coder/coder-xray/jfrog"
1213
"github.com/coder/coder/v2/codersdk"
14+
"github.com/coder/coder/v2/codersdk/agentsdk"
15+
"github.com/coder/retry"
1316

1417
corev1 "k8s.io/api/core/v1"
1518
v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -82,9 +85,18 @@ func (k *K8sReporter) Init(ctx context.Context) error {
8285
return codersdk.JFrogXrayScan{}, xerrors.Errorf("fetch scan results: %w", err)
8386
}
8487

85-
manifest, err := k.CoderClient.AgentManifest(ctx, agentToken)
86-
if err != nil {
87-
return codersdk.JFrogXrayScan{}, xerrors.Errorf("agent manifest: %w", err)
88+
var manifest agentsdk.Manifest
89+
retryCtx, cancel := context.WithTimeout(ctx, time.Minute*10)
90+
defer cancel()
91+
for r := retry.New(time.Second, 5*time.Second); r.Wait(retryCtx); {
92+
manifest, err = k.CoderClient.AgentManifest(retryCtx, agentToken)
93+
if err == nil {
94+
break
95+
}
96+
if xerrors.Is(err, context.Canceled) {
97+
break
98+
}
99+
log.Warn(ctx, "failed to fetch agent manifest", slog.Error(err))
88100
}
89101

90102
log = log.With(

reporter/reporter_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ func TestK8SReporter(t *testing.T) {
6666

6767
jfrogClient.EXPECT().ResultsURL(img, xrayResult.PackageID)
6868

69-
coderClient.EXPECT().AgentManifest(ctx, expectedAgentToken).Return(agentsdk.Manifest{
69+
coderClient.EXPECT().AgentManifest(gomock.Any(), expectedAgentToken).Return(agentsdk.Manifest{
7070
WorkspaceID: expectedWorkspaceID,
7171
AgentID: expectedAgentID,
7272
}, nil)

0 commit comments

Comments
 (0)