Merge pull request #415 from coderoad/fix/linting

Fix/linting

Author: ShMcK

Diff for: .github/workflows/test.yml

@@ -1,6 +1,14 @@
 name: CI
 on: push
 jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Install modules
+        run: yarn install
+      - name: Lint
+        run: yarn lint
   build-extension:
     runs-on: ubuntu-latest
     steps:

Diff for: package.json

@@ -35,29 +35,34 @@
   },
   "dependencies": {
     "@types/assert": "^1.5.1",
-    "@types/jest": "^26.0.5",
+    "@types/jest": "^26.0.8",
     "@types/jsdom": "^16.2.3",
-    "@types/node": "^14.0.24",
+    "@types/node": "^14.0.27",
     "@types/node-fetch": "^2.5.7",
     "@types/semver": "^7.3.1",
-    "@typescript-eslint/eslint-plugin": "^3.7.0",
-    "@typescript-eslint/parser": "^3.7.0",
+    "@typescript-eslint/eslint-plugin": "^3.7.1",
+    "@typescript-eslint/parser": "^3.7.1",
     "chokidar": "^3.4.1",
     "dotenv": "^8.2.0",
-    "eslint": "^7.5.0",
+    "eslint": "^7.6.0",
     "git-url-parse": "^11.1.2",
-    "jest": "^26.1.0",
+    "jest": "^26.2.2",
     "jsdom": "^16.3.0",
     "node-fetch": "^2.6.0",
     "semver": "^7.3.2",
-    "ts-jest": "^26.1.3",
+    "ts-jest": "^26.1.4",
     "typescript": "^3.9.7",
     "vscode-extension-telemetry": "^0.1.6"
   },
   "devDependencies": {
     "eslint-config-prettier": "^6.11.0",
     "eslint-config-react-app": "^5.2.1",
+    "eslint-plugin-flowtype": "^5.2.0",
+    "eslint-plugin-import": "^2.22.0",
+    "eslint-plugin-jsx-a11y": "^6.3.1",
     "eslint-plugin-prettier": "^3.1.4",
+    "eslint-plugin-react": "^7.20.5",
+    "eslint-plugin-react-hooks": "^4.0.8",
     "prettier": "2.0.5",
     "vscode": "^1.1.37",
     "vscode-test": "^1.4.0"

Diff for: src/actions/onErrorPage.ts

@@ -2,7 +2,7 @@ import * as T from 'typings'
 import { readFile } from '../services/node'
 import logger from '../services/logger'
 
-const onErrorPage = async (action: T.Action) => {
+const onErrorPage = async (action: T.Action): void => {
   // Error middleware
   if (action?.payload?.error?.type) {
     // load error markdown message

Diff for: src/actions/onOpenLogs.ts

@@ -1,7 +1,7 @@
 import * as T from 'typings'
 import { showOutput } from '../services/testRunner/output'
 
-export const onOpenLogs = async (action: T.Action) => {
+export const onOpenLogs = async (action: T.Action): void => {
   const channel = action.payload.channel
   await showOutput(channel)
 }

Diff for: src/actions/onRunReset.ts

@@ -11,7 +11,7 @@ type ResetAction = {
 }
 
 // reset to the start of the last test
-const onRunReset = async (action: ResetAction, context: Context) => {
+const onRunReset = async (action: ResetAction, context: Context): void => {
   // reset to timeline
   const tutorial: TT.Tutorial | null = context.tutorial.get()
   const position: T.Position = action.position ? action.position : context.position.get()

Diff for: src/actions/onStartup.ts

@@ -11,7 +11,7 @@ const onStartup = async (
   context: Context,
   workspaceState: vscode.Memento,
   send: (action: T.Action) => Promise<void>,
-) => {
+): void => {
   try {
     // check if a workspace is open, otherwise nothing works
     const noActiveWorkspace = !WORKSPACE_ROOT.length

Diff for: src/actions/onTest.ts

@@ -4,11 +4,11 @@ import * as vscode from 'vscode'
 import { COMMANDS } from '../commands'
 import Context from '../services/context/context'
 
-export const onTestPass = (action: T.Action, context: Context) => {
+export const onTestPass = (action: T.Action, context: Context): void => {
   context.position.set({ ...action.payload.position, complete: true })
   git.saveCommit('Save progress')
 }
 
-export const onRunTest = (action?: T.Action) => {
+export const onRunTest = (action?: T.Action): void => {
   vscode.commands.executeCommand(COMMANDS.RUN_TEST, action?.payload)
 }

Diff for: src/actions/onTutorialConfigContinue.ts

@@ -5,7 +5,7 @@ import Context from '../services/context/context'
 import tutorialConfig from './utils/tutorialConfig'
 import { COMMANDS } from '../commands'
 
-const onTutorialConfigContinue = async (action: T.Action, context: Context, send: any) => {
+const onTutorialConfigContinue = async (action: T.Action, context: Context, send: T.Send): void => {
   try {
     const tutorialContinue: TT.Tutorial | null = context.tutorial.get()
     if (!tutorialContinue) {

Diff for: src/actions/onTutorialConfigNew.ts

@@ -8,7 +8,7 @@ import { version, compareVersions } from '../services/dependencies'
 import Context from '../services/context/context'
 import tutorialConfig from './utils/tutorialConfig'
 
-const onTutorialConfigNew = async (action: T.Action, context: Context, send: any) => {
+const onTutorialConfigNew = async (action: T.Action, context: Context, send: T.Send): void => {
   try {
     const data: TT.Tutorial = action.payload.tutorial
 
@@ -82,7 +82,7 @@ const onTutorialConfigNew = async (action: T.Action, context: Context, send: any
         if (satisfiedDependency !== true) {
           const error: E.ErrorMessage = satisfiedDependency || {
             type: 'UnknownError',
-            message: `Something went wrong comparing dependency for ${name}`,
+            message: `Something went wrong comparing dependency for ${dep.name}`,
             actions: [
               {
                 label: 'Try Again',

Diff for: src/actions/onValidateSetup.ts

@@ -2,7 +2,7 @@ import * as E from 'typings/error'
 import { version } from '../services/dependencies'
 import { checkWorkspaceEmpty } from '../services/workspace'
 
-const onValidateSetup = async (send: any) => {
+const onValidateSetup = async (send: T.Send): void => {
   try {
     // check workspace is selected
     const isEmptyWorkspace = await checkWorkspaceEmpty()

Diff for: typings/index.d.ts

@@ -54,6 +54,8 @@ export interface Action {
   meta?: any
 }
 
+export type Send = (action: Action) => void
+
 export interface Environment {
   machineId: string
   sessionId: string

Diff for: web-app/package.json

@@ -25,10 +25,10 @@
     "extends": "react-app"
   },
   "dependencies": {
-    "@alifd/next": "^1.20.20",
+    "@alifd/next": "^1.20.24",
     "@emotion/babel-preset-css-prop": "^10.0.27",
     "@emotion/core": "^10.0.28",
-    "babel-jest": "^26.1.0",
+    "babel-jest": "^26.2.2",
     "js-yaml": "^3.14.0",
     "markdown-it": "^11.0.0",
     "markdown-it-emoji": "^1.4.0",
@@ -42,7 +42,7 @@
     "xstate": "^4.11.0"
   },
   "devDependencies": {
-    "@babel/core": "^7.10.5",
+    "@babel/core": "^7.11.0",
     "@storybook/addon-actions": "^5.3.19",
     "@storybook/addon-knobs": "^5.3.19",
     "@storybook/addon-links": "^5.3.19",
@@ -51,12 +51,12 @@
     "@storybook/react": "^5.3.19",
     "@types/graphql": "^14.5.0",
     "@types/highlight.js": "^9.12.4",
-    "@types/jest": "^26.0.5",
+    "@types/jest": "^26.0.8",
     "@types/js-yaml": "^3.12.5",
     "@types/markdown-it": "^10.0.1",
-    "@types/node": "^14.0.24",
+    "@types/node": "^14.0.27",
     "@types/prismjs": "^1.16.1",
-    "@types/react": "^16.9.43",
+    "@types/react": "^16.9.44",
     "@types/react-addons-css-transition-group": "^15.0.5",
     "@types/react-dom": "^16.9.8",
     "babel-loader": "8.1.0",